Lucie Kaffee has uploaded a new change for review.
https://gerrit.wikimedia.org/r/262462
Change subject: [WIP] Move references to bottom of the page
......................................................................
[WIP] Move references to bottom of the page
todo: show title for reference section, add references right after value
Bug: T119834
Change-Id: I6a8df414ad097d42aee13ba01bda90ea5b59ff65
---
M includes/Lua/EntityRenderer.lua
1 file changed, 8 insertions(+), 4 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ArticlePlaceholder
refs/changes/62/262462/1
diff --git a/includes/Lua/EntityRenderer.lua b/includes/Lua/EntityRenderer.lua
index 863dd6a..4afb67a 100644
--- a/includes/Lua/EntityRenderer.lua
+++ b/includes/Lua/EntityRenderer.lua
@@ -7,6 +7,7 @@
local util = require( 'libraryUtil' )
local php = mw_interface
+local locframe = mw:getCurrentFrame()
entityrenderer.imageProperty = php.getImageProperty()
local identifierProperties = require( 'Identifier' )
@@ -56,18 +57,20 @@
-- @param table referenceSnak
-- @return String result
local referenceRenderer = function( referenceSnak )
+ local frame = mw:getCurrentFrame()
local result = ''
if referenceSnak ~= nil then
- result = result .. '<h4>' .. mw.message.new(
'articleplaceholder-abouttopic-lua-reference' ):plain() .. '</h4>'
+ --result = result .. '<h4>' .. mw.message.new(
'articleplaceholder-abouttopic-lua-reference' ):plain() .. '</h4>'
local i = 1
while referenceSnak[i] do
for k, v in pairs( referenceSnak[i]['snaks'] ) do
- result = result .. '<p><b>' .. labelRenderer( k ) .. '</b>: '
- result = result .. snaksRenderer( v ) .. '</p>'
+ result = result .. '<b>' .. labelRenderer( k ) .. '</b>: '
+ result = result .. snaksRenderer( v )
end
i = i + 1
end
end
+ result = frame:preprocess( '<ref>' .. result .. '</ref>' )
return result
end
@@ -379,7 +382,8 @@
-- render an entity
entityrenderer.render = function(frame)
local entityID = mw.text.trim( frame.args[1] or "" )
- return renderEntity( entityID )
+ local renderEnt = entityrenderer.getRenderEntity()
+ return renderEnt( entityID )
end
return entityrenderer
--
To view, visit https://gerrit.wikimedia.org/r/262462
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6a8df414ad097d42aee13ba01bda90ea5b59ff65
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ArticlePlaceholder
Gerrit-Branch: master
Gerrit-Owner: Lucie Kaffee <lucie.kaf...@wikimedia.de>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
