[MediaWiki-commits] [Gerrit] Pass jshint and add it to 'npm test' command - change (mediawiki...ContributionTracking)

[Hashar (Code Review)]

Hashar has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/262703

Change subject: Pass jshint and add it to 'npm test' command
......................................................................

Pass jshint and add it to 'npm test' command

Bug: T63599
Change-Id: Ibae36050a1d8054b7280804513a258bc7cd8960f
---
M Gruntfile.js
M modules/jquery.contributionTracking.js
M package.json
3 files changed, 17 insertions(+), 9 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ContributionTracking 
refs/changes/03/262703/1

diff --git a/Gruntfile.js b/Gruntfile.js
index a42ad79..beb732b 100644
--- a/Gruntfile.js
+++ b/Gruntfile.js
@@ -8,12 +8,19 @@
 module.exports = function ( grunt ) {
        'use strict';
        grunt.loadNpmTasks( 'grunt-banana-checker' );
+       grunt.loadNpmTasks( 'grunt-contrib-jshint' );
        grunt.initConfig( {
                banana: {
                        all: ['i18n/']
+               },
+               jshint: {
+                       all: [
+                               '**/*.js',
+                               '!node_modules/**'
+                       ]
                }
        } );
 
-       grunt.registerTask( 'test', [ 'banana' ] );
+       grunt.registerTask( 'test', [ 'jshint', 'banana' ] );
        grunt.registerTask( 'default', 'test' );
 };
diff --git a/modules/jquery.contributionTracking.js 
b/modules/jquery.contributionTracking.js
index 4e54990..3315dd3 100644
--- a/modules/jquery.contributionTracking.js
+++ b/modules/jquery.contributionTracking.js
@@ -40,9 +40,9 @@
                var serializedForm = form.serializeArray();
                var finalObj = {};
 
-               for (key in serializedForm){
-                       if(serializedForm[key]['value'] != ""){
-                               finalObj[serializedForm[key]['name']] = 
serializedForm[key]['value'];
+               for (var key in serializedForm){
+                       if(serializedForm[key].value !== ""){
+                               finalObj[serializedForm[key].name] = 
serializedForm[key].value;
                        }
                }
                return finalObj;
@@ -70,9 +70,9 @@
                                return;
                        }
 
-                       if(data["error"]){
+                       if(data.error){
                                //TODO: localization. And i18n. And stuff.
-                               window.alert("The following error has 
occurred:\r\n" + data["error"]["info"]);
+                               window.alert("The following error has 
occurred:\r\n" + data.error.info);
                                $(buttonID).removeAttr("disabled");
                                $(".ajax_me:disabled").removeAttr("disabled");
                                return;
@@ -85,13 +85,13 @@
                        }
                        $( '#hideyform' ).append( $( '<form></form>', {
                                'id': 'immediate-repost',
-                               'action': data["returns"]["action"]["url"],
+                               'action': data.returns.action.url,
                        } ) );
-                       for ( key in data["returns"]["fields"] ) {
+                       for ( var key in data.returns.fields ) {
                                $( '#immediate_repost' ).append( $( '<input>', {
                                        'id': key,
                                        'name': key,
-                                       'value': data["returns"]["fields"][key],
+                                       'value': data.returns.fields[key],
                                } ) );
                        }
                        $('#immediate_repost').submit();
diff --git a/package.json b/package.json
index 0683523..e43f212 100644
--- a/package.json
+++ b/package.json
@@ -9,6 +9,7 @@
   "devDependencies": {
     "grunt": "0.4.5",
     "grunt-cli": "0.1.13",
+    "grunt-contrib-jshint": "0.11.3",
     "grunt-banana-checker": "0.4.0"
   }
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/262703
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibae36050a1d8054b7280804513a258bc7cd8960f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ContributionTracking
Gerrit-Branch: master
Gerrit-Owner: Hashar <has...@free.fr>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits