Hashar has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/262708

Change subject: tests: mw exts having npm do not need extension-jslint
......................................................................

tests: mw exts having npm do not need extension-jslint

The more specific jobs mwext-*-jslint were introduced so we can make
them non voting until jshint/jsonlint pass.  Whenever npm is already
invoked, it should be used to run jshint/jsonlint.

Test MediaWiki extensions in Zuul having 'npm' template no more have the
'extension-jslint' template.

Change-Id: Ib4755d66369c44da0282d703d4c260434b50b03b
---
A tests/test_zuul_layout.py
1 file changed, 37 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/integration/config 
refs/changes/08/262708/1

diff --git a/tests/test_zuul_layout.py b/tests/test_zuul_layout.py
new file mode 100644
index 0000000..767de0f
--- /dev/null
+++ b/tests/test_zuul_layout.py
@@ -0,0 +1,37 @@
+# Parse Zuul layout.yaml file
+#
+# Copyright (c) 2016 - Antoine "hashar" Musso
+# Copyright (c) 2016 - Wikimedia Foundation Inc.
+
+import os
+import unittest
+
+import yaml
+
+
+class TestZuulLayout(unittest.TestCase):
+
+    layout = None
+
+    @classmethod
+    def setUpClass(cls):
+        wmf_zuul_layout = os.path.join(
+            os.path.dirname(os.path.abspath(__file__)),
+            '../zuul/layout.yaml')
+        with open(wmf_zuul_layout, 'r') as f:
+            cls.layout = yaml.load(f)
+
+    def test_mwext_legacy_jslint_replaced_by_npm(self):
+        exts = sorted([
+            p['name']
+            for p in self.layout['projects']
+            if p['name'].startswith('mediawiki/extensions/')
+            and {'name': 'npm'} in p.get('template', [])
+            and {'name': 'extension-jslint'} in p.get('template', [])
+            ])
+
+        self.maxDiff = None
+        self.longMessage = True
+        self.assertListEqual(
+            [], exts,
+            'MediaWiki extensions having npm do not need "extension-jslint"')

-- 
To view, visit https://gerrit.wikimedia.org/r/262708
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib4755d66369c44da0282d703d4c260434b50b03b
Gerrit-PatchSet: 1
Gerrit-Project: integration/config
Gerrit-Branch: master
Gerrit-Owner: Hashar <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to