DLynch has uploaded a new change for review.
https://gerrit.wikimedia.org/r/262847
Change subject: Stop using broken image links in tests
......................................................................
Stop using broken image links in tests
They make it a little bit more cluttered to hunt down problems when
testing. So, use the minimum image instead of just "Foo" or similar.
Bug: T121636
Change-Id: I3209c377ad870f669cac7d40d991968cff52c39e
---
M lib/ve
M modules/ve-mw/tests/dm/ve.dm.mwExample.js
2 files changed, 8 insertions(+), 8 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/47/262847/1
diff --git a/lib/ve b/lib/ve
index a909501..ca1750e 160000
--- a/lib/ve
+++ b/lib/ve
-Subproject commit a9095015107f9a32ae597b962de1e29d5e7a886a
+Subproject commit ca1750e991198b0c5d9e2a3b95ceff4acd77446c
diff --git a/modules/ve-mw/tests/dm/ve.dm.mwExample.js
b/modules/ve-mw/tests/dm/ve.dm.mwExample.js
index cc968ad..b82283a 100644
--- a/modules/ve-mw/tests/dm/ve.dm.mwExample.js
+++ b/modules/ve-mw/tests/dm/ve.dm.mwExample.js
@@ -256,7 +256,7 @@
ve.dm.mwExample.MWBlockImage = {
html:
'<figure typeof="mw:Image/Thumb" class="mw-halign-right
foobar">' +
- '<a href="Foo"><img src="Bar" width="1" height="2"
resource="FooBar"></a>' +
+ '<a href="Foo"><img src="' + ve.ce.minImgDataUri + '"
width="1" height="2" resource="FooBar"></a>' +
'<figcaption>abc</figcaption>' +
'</figure>',
data: [
@@ -266,7 +266,7 @@
type: 'thumb',
align: 'right',
href: 'Foo',
- src: 'Bar',
+ src: ve.ce.minImgDataUri,
width: 1,
height: 2,
resource: 'FooBar',
@@ -1171,7 +1171,7 @@
'mw:AlienInlineExtension': {
body:
'<p>' +
- '<img src="Foo" width="100" height="20"
alt="Bar" typeof="mw:Extension/score"' +
+ '<img src="' + ve.ce.minImgDataUri + '"
width="100" height="20" alt="Bar" typeof="mw:Extension/score"' +
'
data-mw="{"name":"score","attrs":{},"body":{"extsrc":"\\\\relative
c' { e d c d e e e }"}}" ' +
' data-parsoid="1" about="#mwt1" />' +
'</p>',
@@ -1179,7 +1179,7 @@
'<p>' +
'<span typeof="mw:Extension/score"' +
'
data-mw="{"name":"score","attrs":{},"body":{"extsrc":"\\\\relative
c' { d d d e e e }"}}" ' +
- ' src="Foo" width="100" height="20"
alt="Bar" data-parsoid="1" about="#mwt1" />' +
+ ' src="' + ve.ce.minImgDataUri + '"
width="100" height="20" alt="Bar" data-parsoid="1" about="#mwt1" />' +
'</p>',
data: [
{ type: 'paragraph' },
@@ -1195,7 +1195,7 @@
},
originalMw:
'{"name":"score","attrs":{},"body":{"extsrc":"\\\\relative c\' { e d c d e e e
}"}}'
},
- originalDomElements: $( '<img src="Foo"
width="100" height="20" alt="Bar" about="#mwt1" data-parsoid="1"></img>'
).toArray()
+ originalDomElements: $( '<img src="' +
ve.ce.minImgDataUri + '" width="100" height="20" alt="Bar" about="#mwt1"
data-parsoid="1"></img>' ).toArray()
},
{ type: '/mwAlienInlineExtension' },
{ type: '/paragraph' },
@@ -1913,7 +1913,7 @@
body:
'<figure typeof="mw:Image/Thumb" data-parsoid="{}">' +
'<a href="Foo" data-parsoid="{}">' +
- '<img src="Bar" width="1" height="2"
resource="FooBar" data-parsoid="{}">' +
+ '<img src="' + ve.ce.minImgDataUri + '"
width="1" height="2" resource="FooBar" data-parsoid="{}">' +
'</a>' +
'<figcaption data-parsoid="{}">' +
' foo <a rel="mw:WikiLink" href="./Bar"
data-parsoid="{}">bar</a> baz' +
@@ -1922,7 +1922,7 @@
fromDataBody:
'<figure typeof="mw:Image/Thumb">' +
'<a href="Foo">' +
- '<img src="Bar" width="1" height="2"
resource="FooBar">' +
+ '<img src="' + ve.ce.minImgDataUri + '"
width="1" height="2" resource="FooBar">' +
'</a>' +
'<figcaption>' +
' foo <a rel="mw:WikiLink" href="./Bar">bar</a>
baz' +
@@ -1936,7 +1936,7 @@
type: 'thumb',
align: 'default',
href: 'Foo',
- src: 'Bar',
+ src: ve.ce.minImgDataUri,
width: 1,
height: 2,
resource: 'FooBar'
--
To view, visit https://gerrit.wikimedia.org/r/262847
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3209c377ad870f669cac7d40d991968cff52c39e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: DLynch <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
