Bartosz Dziewoński has uploaded a new change for review.
https://gerrit.wikimedia.org/r/262858
Change subject: ChangeTags: Teach updateTags() to derive log_id from rev_id
(and the other way)
......................................................................
ChangeTags: Teach updateTags() to derive log_id from rev_id (and the other way)
This means that, for example, the tags for a file upload's log entry
and the associated page revision should finally be in sync.
Bug: T122090
Change-Id: I3537278ff728d160bbdcf149d0f99fe9621c02e6
---
M includes/changetags/ChangeTags.php
1 file changed, 16 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/58/262858/1
diff --git a/includes/changetags/ChangeTags.php
b/includes/changetags/ChangeTags.php
index 5aac495..a8c9f7b 100644
--- a/includes/changetags/ChangeTags.php
+++ b/includes/changetags/ChangeTags.php
@@ -212,6 +212,22 @@
);
}
+ if ( $log_id && !$rev_id ) {
+ $rev_id = $dbw->selectField(
+ 'log_search',
+ 'ls_value',
+ array( 'ls_field' => 'associated_rev_id',
'ls_log_id' => $log_id ),
+ __METHOD__
+ );
+ } elseif ( !$log_id && $rev_id ) {
+ $log_id = $dbw->selectField(
+ 'log_search',
+ 'ls_log_id',
+ array( 'ls_field' => 'associated_rev_id',
'ls_value' => $rev_id ),
+ __METHOD__
+ );
+ }
+
// update the tag_summary row
$prevTags = array();
if ( !self::updateTagSummaryRow( $tagsToAdd, $tagsToRemove,
$rc_id, $rev_id,
--
To view, visit https://gerrit.wikimedia.org/r/262858
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3537278ff728d160bbdcf149d0f99fe9621c02e6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
