jenkins-bot has submitted this change and it was merged.
Change subject: Cache engine selection for a given buffer
......................................................................
Cache engine selection for a given buffer
Change-Id: Ie265478f38b29b9af9a14577600399fc55cf569e
---
M wikimedia_thumbor_proxy_engine/__init__.py
1 file changed, 6 insertions(+), 0 deletions(-)
Approvals:
Ori.livneh: Looks good to me, approved
jenkins-bot: Verified
diff --git a/wikimedia_thumbor_proxy_engine/__init__.py
b/wikimedia_thumbor_proxy_engine/__init__.py
index dc52da4..938305b 100644
--- a/wikimedia_thumbor_proxy_engine/__init__.py
+++ b/wikimedia_thumbor_proxy_engine/__init__.py
@@ -40,6 +40,9 @@
self.lcl[module] = klass(context)
def select_engine(self):
+ if self.lcl['selected_engine'] is not None:
+ return self.lcl['selected_engine']
+
for enginename in self.lcl['engines']:
engine = self.lcl[enginename]
try:
@@ -47,6 +50,7 @@
self.lcl['extension'],
self.lcl['buffer']
):
+ self.lcl['selected_engine'] = enginename
return enginename
# Not implementing should_run means that the engine
@@ -54,6 +58,7 @@
# This is required for the stock PIL engine to act as a
# fallback.
except AttributeError:
+ self.lcl['selected_engine'] = enginename
return enginename
raise Exception(
@@ -67,6 +72,7 @@
# buffer and extension are needed by select_engine
self.lcl['extension'] = extension
self.lcl['buffer'] = buffer
+ self.lcl['selected_engine'] = None
# Now that we'll select the right engine, let's initialize it
self.lcl['context'].request_handler.set_header(
--
To view, visit https://gerrit.wikimedia.org/r/260932
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie265478f38b29b9af9a14577600399fc55cf569e
Gerrit-PatchSet: 2
Gerrit-Project: thumbor/proxy-engine
Gerrit-Branch: master
Gerrit-Owner: Gilles <[email protected]>
Gerrit-Reviewer: Filippo Giunchedi <[email protected]>
Gerrit-Reviewer: Gilles <[email protected]>
Gerrit-Reviewer: Giuseppe Lavagetto <[email protected]>
Gerrit-Reviewer: Ori.livneh <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
