jenkins-bot has submitted this change and it was merged.
Change subject: Fixed viewer only displaying every nth image after reopening
......................................................................
Fixed viewer only displaying every nth image after reopening
Added code to detach emit calls when the interface is closed.
Bug: T122785
Change-Id: Ifd97aebe7aa01a152817100f301a80a9b6ac83a3
---
M resources/mmv/mmv.lightboxinterface.js
1 file changed, 5 insertions(+), 0 deletions(-)
Approvals:
Gergő Tisza: Looks good to me, approved
jenkins-bot: Verified
diff --git a/resources/mmv/mmv.lightboxinterface.js
b/resources/mmv/mmv.lightboxinterface.js
index 18b0474..d866d1e 100644
--- a/resources/mmv/mmv.lightboxinterface.js
+++ b/resources/mmv/mmv.lightboxinterface.js
@@ -276,6 +276,11 @@
this.clearEvents();
+ this.buttons.disconnect( this, {
+ 'next': [ 'emit', 'next' ],
+ 'prev': [ 'emit', 'prev' ]
+ } );
+
// We trigger this event on the document because unattach() can
run
// when the interface is unattached
$( document ).trigger( $.Event( 'mmv-close' ) )
--
To view, visit https://gerrit.wikimedia.org/r/262917
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifd97aebe7aa01a152817100f301a80a9b6ac83a3
Gerrit-PatchSet: 7
Gerrit-Project: mediawiki/extensions/MultimediaViewer
Gerrit-Branch: master
Gerrit-Owner: Mhutti1 <[email protected]>
Gerrit-Reviewer: Gergő Tisza <[email protected]>
Gerrit-Reviewer: Mhutti1 <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
