jenkins-bot has submitted this change and it was merged.
Change subject: Update some packages
......................................................................
Update some packages
Change *.js to **/*.js so it can lookf for all js files now.
Update grunt-contrib-jshint to 0.11.3
Update grunt-jscs to 2.6.0
Change-Id: I2f1eda06d278481fa3affb80afcc916a1617bf70
---
M .jshintignore
M Gruntfile.js
M modules/ext.pageTriage.models/ext.pageTriage.revision.js
M modules/ext.pageTriage.views.toolbar/ext.pageTriage.delete.js
M modules/ext.pageTriage.views.toolbar/ext.pageTriage.mark.js
M modules/ext.pageTriage.views.toolbar/ext.pageTriage.tags.js
M package.json
7 files changed, 12 insertions(+), 11 deletions(-)
Approvals:
Hashar: Looks good to me, approved
jenkins-bot: Verified
diff --git a/.jshintignore b/.jshintignore
index 5f2bed5..f080658 100644
--- a/.jshintignore
+++ b/.jshintignore
@@ -1,2 +1,3 @@
+node_modules
modules/external
vendor
diff --git a/Gruntfile.js b/Gruntfile.js
index 76e4a4d..e9f0dfa 100644
--- a/Gruntfile.js
+++ b/Gruntfile.js
@@ -19,8 +19,8 @@
jshintrc: true
},
all: [
- '*.js',
- 'modules/**/*.js',
+ '**/*.js',
+ '!node_modules/**',
'!modules/external/*.js'
]
},
diff --git a/modules/ext.pageTriage.models/ext.pageTriage.revision.js
b/modules/ext.pageTriage.models/ext.pageTriage.revision.js
index f3230ef..d5b2bfd 100644
--- a/modules/ext.pageTriage.models/ext.pageTriage.revision.js
+++ b/modules/ext.pageTriage.models/ext.pageTriage.revision.js
@@ -30,7 +30,7 @@
parse: function ( response ) {
// extract the useful bits of json.
- return response.query.pages[this.pageId].revisions;
+ return response.query.pages[ this.pageId ].revisions;
},
setParams: function ( apiParams ) {
@@ -38,11 +38,11 @@
},
setParam: function ( paramName, paramValue ) {
- this.apiParams[paramName] = paramValue;
+ this.apiParams[ paramName ] = paramValue;
},
getParam: function ( key ) {
- return this.apiParams[key];
+ return this.apiParams[ key ];
}
} );
diff --git a/modules/ext.pageTriage.views.toolbar/ext.pageTriage.delete.js
b/modules/ext.pageTriage.views.toolbar/ext.pageTriage.delete.js
index aa0e4e6..34d56f9 100644
--- a/modules/ext.pageTriage.views.toolbar/ext.pageTriage.delete.js
+++ b/modules/ext.pageTriage.views.toolbar/ext.pageTriage.delete.js
@@ -660,7 +660,7 @@
/**
* Handle an error occuring after submit
*
- * @param {String} msg The error message to display
+ * @param {string} msg The error message to display
*/
handleError: function ( msg ) {
$.removeSpinner( 'delete-spinner' );
diff --git a/modules/ext.pageTriage.views.toolbar/ext.pageTriage.mark.js
b/modules/ext.pageTriage.views.toolbar/ext.pageTriage.mark.js
index 011f9f5..e307c7c 100644
--- a/modules/ext.pageTriage.views.toolbar/ext.pageTriage.mark.js
+++ b/modules/ext.pageTriage.views.toolbar/ext.pageTriage.mark.js
@@ -158,8 +158,8 @@
/**
* Handle an error occuring after submit
*
- * @param {String} action Whether the action was reviewing or
unreviewing
- * @param {String} errorMsg The specific error that occurred
+ * @param {string} action Whether the action was reviewing or
unreviewing
+ * @param {string} errorMsg The specific error that occurred
*/
showMarkError: function ( action, errorMsg ) {
// Give grep a chance to find the usages:
diff --git a/modules/ext.pageTriage.views.toolbar/ext.pageTriage.tags.js
b/modules/ext.pageTriage.views.toolbar/ext.pageTriage.tags.js
index 5b2e3c0..737ecdf 100644
--- a/modules/ext.pageTriage.views.toolbar/ext.pageTriage.tags.js
+++ b/modules/ext.pageTriage.views.toolbar/ext.pageTriage.tags.js
@@ -587,7 +587,7 @@
/**
* Handle an error occuring after submit
*
- * @param {String} msg The error message to display
+ * @param {string} msg The error message to display
*/
handleError: function ( msg ) {
$.removeSpinner( 'tag-spinner' );
diff --git a/package.json b/package.json
index 3dd9c64..4bffece 100644
--- a/package.json
+++ b/package.json
@@ -11,10 +11,10 @@
"grunt": "0.4.5",
"grunt-cli": "0.1.13",
"grunt-contrib-csslint": "0.4.0",
- "grunt-contrib-jshint": "0.11.2",
+ "grunt-contrib-jshint": "0.11.3",
"grunt-contrib-watch": "0.6.1",
"grunt-banana-checker": "0.4.0",
- "grunt-jscs": "1.8.0",
+ "grunt-jscs": "2.6.0",
"grunt-jsonlint": "1.0.7"
}
}
--
To view, visit https://gerrit.wikimedia.org/r/262885
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2f1eda06d278481fa3affb80afcc916a1617bf70
Gerrit-PatchSet: 5
Gerrit-Project: mediawiki/extensions/PageTriage
Gerrit-Branch: master
Gerrit-Owner: Paladox <[email protected]>
Gerrit-Reviewer: Hashar <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: Legoktm <[email protected]>
Gerrit-Reviewer: Umherirrender <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
