Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/263060
Change subject: Add missing type hints to LanguageWithConversion
......................................................................
Add missing type hints to LanguageWithConversion
Change-Id: I47e1947654b69582739b6b2d4c53d1108bef7386
---
M lib/includes/LanguageWithConversion.php
1 file changed, 46 insertions(+), 11 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/60/263060/1
diff --git a/lib/includes/LanguageWithConversion.php
b/lib/includes/LanguageWithConversion.php
index 02e35bd..43461f6 100644
--- a/lib/includes/LanguageWithConversion.php
+++ b/lib/includes/LanguageWithConversion.php
@@ -13,16 +13,45 @@
*/
class LanguageWithConversion {
- static protected $objectCache = array();
+ /**
+ * @var array[]
+ */
+ static private $objectCache = array();
- protected $language;
- protected $languageCode;
- protected $sourceLanguage;
- protected $sourceLanguageCode;
- protected $parentLanguage;
+ /**
+ * @var Language|null
+ */
+ private $language;
- protected $translateCache = array();
- protected $translatePool = array();
+ /**
+ * @var string
+ */
+ private $languageCode;
+
+ /**
+ * @var Language|null
+ */
+ private $sourceLanguage;
+
+ /**
+ * @var string|null
+ */
+ private $sourceLanguageCode;
+
+ /**
+ * @var Language|null
+ */
+ private $parentLanguage;
+
+ /**
+ * @var string[]
+ */
+ private $translateCache = array();
+
+ /**
+ * @var bool[]
+ */
+ private $translatePool = array();
/**
* @param null|Language $language
@@ -31,7 +60,13 @@
* @param null|string $sourceLanguageCode
* @param null|Language $parentLanguage
*/
- protected function __construct( $language, $languageCode,
$sourceLanguage, $sourceLanguageCode, $parentLanguage ) {
+ private function __construct(
+ Language $language = null,
+ $languageCode,
+ Language $sourceLanguage = null,
+ $sourceLanguageCode = null,
+ Language $parentLanguage = null
+ ) {
$this->language = $language;
$this->languageCode = $languageCode;
$this->sourceLanguage = $sourceLanguage;
@@ -142,7 +177,7 @@
/**
* Get the code of the source language defined.
*
- * @return string
+ * @return string|null
*/
public function getSourceLanguageCode() {
return $this->sourceLanguageCode;
@@ -244,7 +279,7 @@
/**
* Really execute translation.
*/
- protected function executeTranslate() {
+ private function executeTranslate() {
if ( $this->parentLanguage && count( $this->translatePool ) ) {
$pieces = array_keys( $this->translatePool );
$block = implode( "\0", $pieces );
--
To view, visit https://gerrit.wikimedia.org/r/263060
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I47e1947654b69582739b6b2d4c53d1108bef7386
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
