Legoktm has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/263187

Change subject: Don't install dev dependencies via composer
......................................................................

Don't install dev dependencies via composer

Change-Id: Ia76c838e9a2f5922da8a9206fd11d857a95df978
---
M nightly.py
1 file changed, 9 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/labs/tools/extdist 
refs/changes/87/263187/1

diff --git a/nightly.py b/nightly.py
index 84b128f..66e6c1f 100644
--- a/nightly.py
+++ b/nightly.py
@@ -177,12 +177,15 @@
                 logging.debug('No updates to branch, tarball already exists.')
                 continue
             if self.COMPOSER and os.path.exists('composer.json'):
-                logging.debug('Running composer install for %s' % ext)
-                try:
-                    self.shell_exec([self.COMPOSER, 'install'])
-                except subprocess.CalledProcessError:
-                    logging.error(traceback.format_exc())
-                    logging.error('composer install failed')
+                with open('composer.json') as f_composer:
+                    d_composer = json.load(f_composer)
+                if 'require' in d_composer:
+                    logging.debug('Running composer install for %s' % ext)
+                    try:
+                        self.shell_exec([self.COMPOSER, 'install', '--no-dev'])
+                    except subprocess.CalledProcessError:
+                        logging.error(traceback.format_exc())
+                        logging.error('composer install failed')
             # Create gitinfo.json to be read/displayed by Special:Version
             git_info = {}
             with open('.git/HEAD') as f_head:

-- 
To view, visit https://gerrit.wikimedia.org/r/263187
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia76c838e9a2f5922da8a9206fd11d857a95df978
Gerrit-PatchSet: 1
Gerrit-Project: labs/tools/extdist
Gerrit-Branch: master
Gerrit-Owner: Legoktm <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to