jenkins-bot has submitted this change and it was merged.
Change subject: Fix undefined index error, when WikidataPageBanner isn't
installed
......................................................................
Fix undefined index error, when WikidataPageBanner isn't installed
Bug: T123169
Change-Id: If69946ba437b649e8cd61daeba0f8d16f56679be
---
M includes/MobileFrontend.hooks.php
1 file changed, 5 insertions(+), 1 deletion(-)
Approvals:
Alex Monk: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/MobileFrontend.hooks.php
b/includes/MobileFrontend.hooks.php
index 9ab887c..a949fb5 100644
--- a/includes/MobileFrontend.hooks.php
+++ b/includes/MobileFrontend.hooks.php
@@ -698,7 +698,11 @@
$mfMobileUrlTemplate = $context->getMobileUrlTemplate();
$tabletSize = $config->get( 'MFDeviceWidthTablet' );
- if ( $context->isBetaGroupMember() ) {
+ // show banners using WikidataPageBanner, if installed and all
pre-conditions fulfilled
+ if (
+ ExtensionRegistry::getInstance()->isLoaded(
'WikidataPageBanner' ) &&
+ $context->isBetaGroupMember()
+ ) {
// turn default banners on
$wgWPBEnableDefaultBanner = true;
// Turn on the banner experiment
--
To view, visit https://gerrit.wikimedia.org/r/263172
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If69946ba437b649e8cd61daeba0f8d16f56679be
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Florianschmidtwelzow <[email protected]>
Gerrit-Reviewer: Alex Monk <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
