UltrasonicNXT has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/263221

Change subject: Define style position
......................................................................

Define style position

I am getting errors in my logs like "PHP Warning:
OutputPage::getModuleStyles: style module should define its
position explicitly: jquery.articleFeedbackv5.special
ResourceLoaderFileModule"

I think this should fix

Change-Id: I7547f98be973bacbb283502811a52d10dda6f049
---
M ArticleFeedbackv5.php
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ArticleFeedbackv5 
refs/changes/21/263221/1

diff --git a/ArticleFeedbackv5.php b/ArticleFeedbackv5.php
index 3986917..5749ce5 100644
--- a/ArticleFeedbackv5.php
+++ b/ArticleFeedbackv5.php
@@ -909,6 +909,7 @@
                'json',
                'jquery.ui.button',
        ),
+       'position' => 'top'
 ) + $wgArticleFeedbackResourcePaths;
 
 /*

-- 
To view, visit https://gerrit.wikimedia.org/r/263221
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7547f98be973bacbb283502811a52d10dda6f049
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ArticleFeedbackv5
Gerrit-Branch: REL1_26
Gerrit-Owner: UltrasonicNXT <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to