jenkins-bot has submitted this change and it was merged. Change subject: Fix documentation of StatementGrouperBuilder ......................................................................
Fix documentation of StatementGrouperBuilder We talked about an "identifier" data type for months, and that's what I still believed when I wrote this. But it's called "external-id" now. Change-Id: Ibdcb1efc25b5034f0a16ab1bd0dad0daaaf26203 --- M repo/includes/StatementGrouperBuilder.php 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Hoo man: Looks good to me, approved jenkins-bot: Verified diff --git a/repo/includes/StatementGrouperBuilder.php b/repo/includes/StatementGrouperBuilder.php index 0b399e4..568e29e 100644 --- a/repo/includes/StatementGrouperBuilder.php +++ b/repo/includes/StatementGrouperBuilder.php @@ -25,7 +25,7 @@ * ), * 'identifiers' => array( * 'type' => 'dataType', - * 'dataTypes' => array( 'identifier' ), + * 'dataTypes' => array( 'external-id' ), * ), * ), * 'property' => array( -- To view, visit https://gerrit.wikimedia.org/r/263070 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibdcb1efc25b5034f0a16ab1bd0dad0daaaf26203 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Thiemo Mättig (WMDE) <[email protected]> Gerrit-Reviewer: Bene <[email protected]> Gerrit-Reviewer: Daniel Kinzler <[email protected]> Gerrit-Reviewer: Hoo man <[email protected]> Gerrit-Reviewer: Jonas Kress (WMDE) <[email protected]> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
