VolkerE has uploaded a new change for review.
https://gerrit.wikimedia.org/r/263543
Change subject: MediaWiki theme: Clarify `@text` variable by renaming it
......................................................................
MediaWiki theme: Clarify `@text` variable by renaming it
Clarifying application of `@text` variable by renaming it to
`@color-default` as it's the default foreground color. Accompaying
changes to `@text-pressed` and `@color-pressed` to clarify their usage
as well.
Change-Id: I3e08b526c0aeaff1ea8effc2f07f02415355f809
---
M src/themes/mediawiki/common.less
M src/themes/mediawiki/elements.less
M src/themes/mediawiki/widgets.less
M src/themes/mediawiki/windows.less
4 files changed, 13 insertions(+), 12 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/43/263543/1
diff --git a/src/themes/mediawiki/common.less b/src/themes/mediawiki/common.less
index ff31be3..af09051 100644
--- a/src/themes/mediawiki/common.less
+++ b/src/themes/mediawiki/common.less
@@ -23,9 +23,10 @@
@destructive-selected: #73100a;
@destructive-fade: rgba( 209, 29, 19, 0.1 );
-@text: #555;
-@pressed-text: #444;
-@pressed-color: #d0d0d0; // Used for borders and backgrounds
+@color-default: #555;
+@color-default-pressed: #444;
+@background-color-pressed: #d0d0d0;
+
@disabled-text: #ccc;
@disabled-framed-text: #fff;
@disabled-background: #ddd;
diff --git a/src/themes/mediawiki/elements.less
b/src/themes/mediawiki/elements.less
index 2b33313..ad7b0d2 100644
--- a/src/themes/mediawiki/elements.less
+++ b/src/themes/mediawiki/elements.less
@@ -60,12 +60,12 @@
&.oo-ui-widget-enabled {
> input.oo-ui-buttonElement-button,
> .oo-ui-buttonElement-button >
.oo-ui-labelElement-label {
- color: @text;
+ color: @color-default;
}
&.oo-ui-buttonElement-pressed >
input.oo-ui-buttonElement-button,
&.oo-ui-buttonElement-pressed >
.oo-ui-buttonElement-button > .oo-ui-labelElement-label {
- color: @pressed-text;
+ color: @color-default-pressed;
}
&.oo-ui-flaggedElement {
@@ -171,7 +171,7 @@
&.oo-ui-widget-enabled {
> .oo-ui-buttonElement-button {
- color: @text;
+ color: @color-default;
background-color: @background;
border: @neutral-button-border;
diff --git a/src/themes/mediawiki/widgets.less
b/src/themes/mediawiki/widgets.less
index c38f1f8..7b97687 100644
--- a/src/themes/mediawiki/widgets.less
+++ b/src/themes/mediawiki/widgets.less
@@ -790,7 +790,7 @@
background-color: #eee;
border: 1px solid #ccc;
- color: @text;
+ color: @color-default;
border-radius: 0.1em;
&.oo-ui-indicatorElement {
@@ -842,7 +842,7 @@
.oo-ui-selectWidget-pressed &-pressed,
.oo-ui-selectWidget-pressed &-pressed&-highlighted,
.oo-ui-selectWidget-pressed &-pressed&-highlighted&-selected {
- background-color: @pressed-color;
+ background-color: @background-color-pressed;
}
&.oo-ui-widget-disabled {
@@ -983,7 +983,7 @@
}
.oo-ui-selectWidget-depressed &.oo-ui-optionWidget-selected {
- background-color: @pressed-color;
+ background-color: @background-color-pressed;
text-shadow: 0 1px 1px #fff;
}
@@ -1012,7 +1012,7 @@
border-bottom: none;
border-top-left-radius: @border-radius;
border-top-right-radius: @border-radius;
- color: @text;
+ color: @color-default;
font-weight: bold;
&.oo-ui-widget-enabled {
@@ -1223,7 +1223,7 @@
width: 1.2em;
height: 1.2em;
border-radius: 1.2em;
- background-color: @text;
+ background-color: #555;
.oo-ui-transition(
left @transition-ease-quick,
margin-left @transition-ease-quick
diff --git a/src/themes/mediawiki/windows.less
b/src/themes/mediawiki/windows.less
index 24ed1e5..7506c50 100644
--- a/src/themes/mediawiki/windows.less
+++ b/src/themes/mediawiki/windows.less
@@ -30,7 +30,7 @@
&-message {
font-size: 0.9em;
line-height: 1.25em;
- color: @text;
+ color: @color-default;
&-verbose {
font-size: 1.1em;
--
To view, visit https://gerrit.wikimedia.org/r/263543
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3e08b526c0aeaff1ea8effc2f07f02415355f809
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: VolkerE <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
