jenkins-bot has submitted this change and it was merged.
Change subject: Send escape key cancel events through action handler
......................................................................
Send escape key cancel events through action handler
Instead of just closing straight away
Bug: T121673
Change-Id: Ieaf19fe4485b679e0ee21d16f8f2e0693808f386
---
M src/Dialog.js
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Bartosz Dziewoński: Looks good to me, approved
jenkins-bot: Verified
diff --git a/src/Dialog.js b/src/Dialog.js
index e7663fb..9414d40 100644
--- a/src/Dialog.js
+++ b/src/Dialog.js
@@ -136,7 +136,7 @@
*/
OO.ui.Dialog.prototype.onDialogKeyDown = function ( e ) {
if ( e.which === OO.ui.Keys.ESCAPE ) {
- this.close();
+ this.executeAction( '' );
e.preventDefault();
e.stopPropagation();
}
--
To view, visit https://gerrit.wikimedia.org/r/263547
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ieaf19fe4485b679e0ee21d16f8f2e0693808f386
Gerrit-PatchSet: 2
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Alex Monk <[email protected]>
Gerrit-Reviewer: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: Esanders <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
