Dbrant has uploaded a new change for review. https://gerrit.wikimedia.org/r/263834
Change subject: Update event logging for intents. ...................................................................... Update event logging for intents. This adds event logging for the new ACTION_PROCESS_TEXT intent. It also rolls widget-based launch events into the same schema, and also adds event logging for the SEND intent, which we weren't logging previously. https://meta.wikimedia.org/wiki/Schema:MobileWikiAppIntents Bug: T121910 Change-Id: I318bf591d5b7a68023948464c656e35d09f0b6a5 --- A app/src/main/java/org/wikipedia/analytics/IntentFunnel.java D app/src/main/java/org/wikipedia/analytics/WidgetsFunnel.java M app/src/main/java/org/wikipedia/page/PageActivity.java 3 files changed, 46 insertions(+), 38 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia refs/changes/34/263834/1 diff --git a/app/src/main/java/org/wikipedia/analytics/IntentFunnel.java b/app/src/main/java/org/wikipedia/analytics/IntentFunnel.java new file mode 100644 index 0000000..89b1099 --- /dev/null +++ b/app/src/main/java/org/wikipedia/analytics/IntentFunnel.java @@ -0,0 +1,41 @@ +package org.wikipedia.analytics; + +import android.support.annotation.NonNull; + +import org.json.JSONObject; +import org.wikipedia.WikipediaApp; + +public class IntentFunnel extends Funnel { + private static final String SCHEMA_NAME = "MobileWikiAppIntents"; + private static final int REV_ID = 15237384; + + public IntentFunnel(WikipediaApp app) { + super(app, SCHEMA_NAME, REV_ID); + } + + public void logSearchWidgetTap() { + log( + "action", "searchwidgettap" + ); + } + + public void logFeaturedArticleWidgetTap() { + log( + "action", "featuredarticlewidgettap" + ); + } + + public void logShareIntent() { + log( + "action", "share" + ); + } + + public void logProcessTextIntent() { + log( + "action", "processtext" + ); + } + + @Override protected void preprocessSessionToken(@NonNull JSONObject eventData) { } +} \ No newline at end of file diff --git a/app/src/main/java/org/wikipedia/analytics/WidgetsFunnel.java b/app/src/main/java/org/wikipedia/analytics/WidgetsFunnel.java deleted file mode 100644 index d6e9df5..0000000 --- a/app/src/main/java/org/wikipedia/analytics/WidgetsFunnel.java +++ /dev/null @@ -1,29 +0,0 @@ -package org.wikipedia.analytics; - -import android.support.annotation.NonNull; - -import org.json.JSONObject; -import org.wikipedia.WikipediaApp; - -public class WidgetsFunnel extends Funnel { - private static final String SCHEMA_NAME = "MobileWikiAppWidgets"; - private static final int REV_ID = 11312870; - - public WidgetsFunnel(WikipediaApp app) { - super(app, SCHEMA_NAME, REV_ID); - } - - public void logSearchWidgetTap() { - log( - "action", "searchwidgettap" - ); - } - - public void logFeaturedArticleWidgetTap() { - log( - "action", "featuredarticlewidgettap" - ); - } - - @Override protected void preprocessSessionToken(@NonNull JSONObject eventData) { } -} \ No newline at end of file diff --git a/app/src/main/java/org/wikipedia/page/PageActivity.java b/app/src/main/java/org/wikipedia/page/PageActivity.java index 115fa71..930299f 100644 --- a/app/src/main/java/org/wikipedia/page/PageActivity.java +++ b/app/src/main/java/org/wikipedia/page/PageActivity.java @@ -7,7 +7,7 @@ import org.wikipedia.activity.ThemedActionBarActivity; import org.wikipedia.ViewAnimations; import org.wikipedia.WikipediaApp; -import org.wikipedia.analytics.WidgetsFunnel; +import org.wikipedia.analytics.IntentFunnel; import org.wikipedia.events.ChangeTextSizeEvent; import org.wikipedia.events.ThemeChangeEvent; import org.wikipedia.events.WikipediaZeroStateChangeEvent; @@ -426,21 +426,17 @@ loadPageInForegroundTab(title, historyEntry); } else if (Intent.ACTION_SEND.equals(intent.getAction()) && PLAIN_TEXT_MIME_TYPE.equals(intent.getType())) { - // Share menu. + new IntentFunnel(app).logShareIntent(); handleShareIntent(intent); } else if (Intent.ACTION_PROCESS_TEXT.equals(intent.getAction()) && PLAIN_TEXT_MIME_TYPE.equals(intent.getType())) { - // Process text. + new IntentFunnel(app).logProcessTextIntent(); handleProcessTextIntent(intent); } else if (intent.hasExtra(EXTRA_SEARCH_FROM_WIDGET)) { - // Log that the user tapped on the search widget - // Instantiate the funnel anonymously to save on memory overhead - new WidgetsFunnel(app).logSearchWidgetTap(); + new IntentFunnel(app).logSearchWidgetTap(); openSearch(); } else if (intent.hasExtra(EXTRA_FEATURED_ARTICLE_FROM_WIDGET)) { - // Log that the user tapped on the featured article widget - // Instantiate the funnel anonymously to save on memory overhead - new WidgetsFunnel(app).logFeaturedArticleWidgetTap(); + new IntentFunnel(app).logFeaturedArticleWidgetTap(); loadMainPageInForegroundTab(); } else { loadMainPageIfNoTabs(); -- To view, visit https://gerrit.wikimedia.org/r/263834 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I318bf591d5b7a68023948464c656e35d09f0b6a5 Gerrit-PatchSet: 1 Gerrit-Project: apps/android/wikipedia Gerrit-Branch: master Gerrit-Owner: Dbrant <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
