jenkins-bot has submitted this change and it was merged.
Change subject: Fix language selection from suggester
......................................................................
Fix language selection from suggester
The `languagesuggesterchange` event handler overwrites `_selectedValue`, so
`change` has to be triggered before setting `_selectedValue`.
Change-Id: Id85913da2b09171711bb51a5fcd11e38f136648a
---
M lib/jquery.ui/jquery.ui.languagesuggester.js
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jonas Kress (WMDE): Looks good to me, approved
jenkins-bot: Verified
diff --git a/lib/jquery.ui/jquery.ui.languagesuggester.js
b/lib/jquery.ui/jquery.ui.languagesuggester.js
index 3676538..45789f0 100644
--- a/lib/jquery.ui/jquery.ui.languagesuggester.js
+++ b/lib/jquery.ui/jquery.ui.languagesuggester.js
@@ -33,9 +33,9 @@
$( retVal )
.on( 'selected.languagesuggester', function( event, item ) {
+ self._trigger( 'change' );
self._selectedValue = item.getValue();
self.element.val( item.getLabel() );
- self._trigger( 'change' );
} );
return retVal;
--
To view, visit https://gerrit.wikimedia.org/r/263839
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id85913da2b09171711bb51a5fcd11e38f136648a
Gerrit-PatchSet: 1
Gerrit-Project: data-values/value-view
Gerrit-Branch: master
Gerrit-Owner: Adrian Lang <[email protected]>
Gerrit-Reviewer: Jonas Kress (WMDE) <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
