Aaron Schulz has uploaded a new change for review.
https://gerrit.wikimedia.org/r/263841
Change subject: Remove pointless rollback() warnings with "flush"
......................................................................
Remove pointless rollback() warnings with "flush"
This would previously make log noise when rollbackMasterChangesAndLog() runs
Change-Id: I36dd955a89b23ed6d1ea693cf5366c7d3ad8d3af
---
M includes/db/Database.php
1 file changed, 0 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/41/263841/1
diff --git a/includes/db/Database.php b/includes/db/Database.php
index 4684e43..6e1b8a9 100644
--- a/includes/db/Database.php
+++ b/includes/db/Database.php
@@ -2685,8 +2685,6 @@
if ( !$this->mTrxLevel ) {
wfWarn( "$fname: No transaction to rollback,
something got out of sync!" );
return; // nothing to do
- } elseif ( $this->mTrxAutomatic ) {
- wfWarn( "$fname: Explicit rollback of implicit
transaction. Something may be out of sync!" );
}
} else {
if ( !$this->mTrxLevel ) {
--
To view, visit https://gerrit.wikimedia.org/r/263841
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I36dd955a89b23ed6d1ea693cf5366c7d3ad8d3af
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Aaron Schulz <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
