Aaron Schulz has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/263853

Change subject: Remove unnecessary DB begin/commit calls
......................................................................

Remove unnecessary DB begin/commit calls

Change-Id: I27358deff2c31b8ba654a3ff2fd8f4f90ea7d329
---
M SpecialMoodleWS.php
1 file changed, 0 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Moodle 
refs/changes/53/263853/1

diff --git a/SpecialMoodleWS.php b/SpecialMoodleWS.php
index ee6cbd1..35c4e32 100644
--- a/SpecialMoodleWS.php
+++ b/SpecialMoodleWS.php
@@ -20,7 +20,6 @@
                global $wgUser;
 
                $dbw = wfGetDB( DB_MASTER );
-               $dbw->begin( __METHOD__ );
                # Do queries
                $res = $dbw->insert(
                        'moodleusers',
@@ -30,7 +29,6 @@
                        __METHOD__,
                        array()
                );
-               $dbw->commit( __METHOD__ );
                # function insert( $table, $a, $fname = 'Database::insert', 
$options = array() );
        }
 

-- 
To view, visit https://gerrit.wikimedia.org/r/263853
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I27358deff2c31b8ba654a3ff2fd8f4f90ea7d329
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Moodle
Gerrit-Branch: master
Gerrit-Owner: Aaron Schulz <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to