OliverKeyes has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/264027

Change subject: Fix portal data retrieval bug introduced by the new A/B test
......................................................................

Fix portal data retrieval bug introduced by the new A/B test

As well as NULL and 'null', we're now using 'baseline' to refer
to 'not in the test'.

(╯°□°)╯︵ ┻━┻

This fixes that.

Bug: T123597
Change-Id: I60349796471cdb9592e39ffacedb0df8243562ab
---
M portal/portal.R
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/wikimedia/discovery/golden 
refs/changes/27/264027/1

diff --git a/portal/portal.R b/portal/portal.R
index 0210525..6a46e34 100644
--- a/portal/portal.R
+++ b/portal/portal.R
@@ -12,7 +12,7 @@
                      timestamp AS ts",
                      date = date,
                      table = table,
-                     conditionals = "((event_cohort IS NULL) OR (event_cohort 
= 'null'))")
+                     conditionals = "((event_cohort IS NULL) OR (event_cohort 
IN ('null','baseline')))")
   stop_on_empty(data)
   
   # Sanitise

-- 
To view, visit https://gerrit.wikimedia.org/r/264027
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I60349796471cdb9592e39ffacedb0df8243562ab
Gerrit-PatchSet: 1
Gerrit-Project: wikimedia/discovery/golden
Gerrit-Branch: master
Gerrit-Owner: OliverKeyes <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to