Alexandros Kosiaris has submitted this change and it was merged.
Change subject: Incorrect syntax in RCStreamCollector.collect
......................................................................
Incorrect syntax in RCStreamCollector.collect
`except IOError, ValueError:` assigns the exception to ValueError.
Added in 21be64bf.
Change-Id: I361261b2ba58d44fd0774859432f720790aca980
---
M modules/rcstream/files/diamond_collector.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Giuseppe Lavagetto: Looks good to me, but someone else must approve
Alexandros Kosiaris: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/rcstream/files/diamond_collector.py
b/modules/rcstream/files/diamond_collector.py
index 5ea44bb..3be0d87 100644
--- a/modules/rcstream/files/diamond_collector.py
+++ b/modules/rcstream/files/diamond_collector.py
@@ -40,7 +40,7 @@
for backend in backends:
try:
stat = self.get_backend_stats(backend)
- except IOError, ValueError:
+ except (IOError, ValueError):
self.log.exception('Failed to check backend %s', backend)
else:
stats.append(stat)
--
To view, visit https://gerrit.wikimedia.org/r/263848
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I361261b2ba58d44fd0774859432f720790aca980
Gerrit-PatchSet: 2
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: John Vandenberg <[email protected]>
Gerrit-Reviewer: Alexandros Kosiaris <[email protected]>
Gerrit-Reviewer: Giuseppe Lavagetto <[email protected]>
Gerrit-Reviewer: Hashar <[email protected]>
Gerrit-Reviewer: Ori.livneh <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
