DLynch has uploaded a new change for review.
https://gerrit.wikimedia.org/r/264098
Change subject: Links in focusableNodes: shouldn't look clickable
......................................................................
Links in focusableNodes: shouldn't look clickable
Not using pointer-events:none for this, because that winds up suppressing the
highlight in some cases. This solution isn't perfect, since people using
uncommon skins for link hover effects will still experience those effects, but
it works for the common case.
Bug: T100275
Change-Id: I967351e1cad2b26bd511f434e9677e6cbc6a85d8
---
M src/ce/styles/nodes/ve.ce.FocusableNode.css
1 file changed, 8 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor
refs/changes/98/264098/1
diff --git a/src/ce/styles/nodes/ve.ce.FocusableNode.css
b/src/ce/styles/nodes/ve.ce.FocusableNode.css
index a950638..6689f6a 100644
--- a/src/ce/styles/nodes/ve.ce.FocusableNode.css
+++ b/src/ce/styles/nodes/ve.ce.FocusableNode.css
@@ -22,7 +22,8 @@
opacity: 0.15;
}
-.ve-ce-focusableNode {
+.ve-ce-focusableNode,
+.ve-ce-focusableNode a {
cursor: default;
}
@@ -35,6 +36,12 @@
}
/*csslint vendor-prefix: true, compatible-vendor-prefixes:true */
+.ve-ce-focusableNode a:hover,
+a.ve-ce-focusableNode:hover {
+ /* Don't look like we're a clickable link (e.g. a broken template link)
*/
+ text-decoration: none;
+}
+
.ve-ce-focusableNode-highlight {
background: #6da9f7;
box-shadow: inset 0 0 0 1px #4C76ac;
--
To view, visit https://gerrit.wikimedia.org/r/264098
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I967351e1cad2b26bd511f434e9677e6cbc6a85d8
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: DLynch <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
