Hoo man has uploaded a new change for review.
https://gerrit.wikimedia.org/r/264458
Change subject: Restructure WikimediaBadges hook handler and add tests
......................................................................
Restructure WikimediaBadges hook handler and add tests
In order to make it ready to have more and more advanced
hook handlers with tests.
Change-Id: I227584f8f17571e5244da5237bd14357a17cee28
---
M WikimediaBadges.php
M composer.json
R includes/BeforePageDisplayHookHandler.php
A tests/phpunit/includes/BeforePageDisplayHookHandlerTest.php
4 files changed, 38 insertions(+), 2 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikimediaBadges
refs/changes/58/264458/1
diff --git a/WikimediaBadges.php b/WikimediaBadges.php
index fab7388..bc7d57c 100644
--- a/WikimediaBadges.php
+++ b/WikimediaBadges.php
@@ -47,6 +47,11 @@
// Hooks
$wgHooks['BeforePageDisplay'][] =
'WikimediaBadges\Hooks::onBeforePageDisplay';
+ // Register phpunit tests
+ $wgHooks['UnitTestsList'][] = function( array &$files ) {
+ $files[] = __DIR__ . '/tests/phpunit';
+ };
+
// Resource Loader modules
$wgResourceModules = array_merge( $wgResourceModules, include( __DIR__
. '/resources/Resources.php' ) );
diff --git a/composer.json b/composer.json
index bec0688..14c861d 100644
--- a/composer.json
+++ b/composer.json
@@ -28,7 +28,7 @@
"WikimediaBadges.php"
],
"classmap": [
- "WikimediaBadges.hooks.php"
+ "includes/"
]
}
}
diff --git a/WikimediaBadges.hooks.php
b/includes/BeforePageDisplayHookHandler.php
similarity index 92%
rename from WikimediaBadges.hooks.php
rename to includes/BeforePageDisplayHookHandler.php
index 33a1845..2ecfa14 100644
--- a/WikimediaBadges.hooks.php
+++ b/includes/BeforePageDisplayHookHandler.php
@@ -13,7 +13,7 @@
* @license GNU GPL v2+
* @author Bene* < benestar.wikime...@gmail.com >
*/
-final class Hooks {
+class BeforePageDisplayHookHandler {
/**
* Handler for the BeforePageDisplay hook
diff --git a/tests/phpunit/includes/BeforePageDisplayHookHandlerTest.php
b/tests/phpunit/includes/BeforePageDisplayHookHandlerTest.php
new file mode 100644
index 0000000..9a409b7
--- /dev/null
+++ b/tests/phpunit/includes/BeforePageDisplayHookHandlerTest.php
@@ -0,0 +1,31 @@
+<?php
+
+namespace WikimediaBadges\Tests;
+
+use PHPUnit_Framework_TestCase;
+use SkinTemplate;
+use WikimediaBadges\BeforePageDisplayHookHandler;
+
+/**
+ * @covers WikimediaBadges\BeforePageDisplayHookHandler
+ *
+ * @group WikimediaBadges
+ *
+ * @license GNU GPL v2+
+ * @author Marius Hoch < h...@online.de >
+ */
+class BeforePageDisplayHookHandlerTest extends PHPUnit_Framework_TestCase {
+
+ public function testOnBeforePageDisplay() {
+ $skin = new SkinTemplate();
+ $out = $this->getMockBuilder( 'OutputPage' )
+ ->disableOriginalConstructor()
+ ->getMock();
+ $out->expects( $this->once() )
+ ->method( 'addModuleStyles' )
+ ->with( 'ext.wikimediaBadges' );
+
+ $this->assertTrue(
BeforePageDisplayHookHandler::onBeforePageDisplay( $out, $skin ) );
+ }
+
+}
--
To view, visit https://gerrit.wikimedia.org/r/264458
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I227584f8f17571e5244da5237bd14357a17cee28
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikimediaBadges
Gerrit-Branch: master
Gerrit-Owner: Hoo man <h...@online.de>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
