VolkerE has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/264581

Change subject: MediaWiki theme: Apply `:hover` color to textInputWidgets
......................................................................

MediaWiki theme: Apply `:hover` color to textInputWidgets

Applying `:hover` color to textInputWidgets. Also merging false
`@border-button-neutral` variable into new `@border-default`.

Bug: T123860
Change-Id: Ic850297a47e64c015d070be5cb012c57df6d58d5
---
M src/themes/mediawiki/common.less
M src/themes/mediawiki/elements.less
M src/themes/mediawiki/tools.less
M src/themes/mediawiki/widgets.less
4 files changed, 20 insertions(+), 17 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/81/264581/1

diff --git a/src/themes/mediawiki/common.less b/src/themes/mediawiki/common.less
index 9605c65..6f44f2c 100644
--- a/src/themes/mediawiki/common.less
+++ b/src/themes/mediawiki/common.less
@@ -42,7 +42,8 @@
 // Invalid Widget (validation error feedback)
 @color-invalid: #f00;
 
-@border-button-neutral: 1px solid #cdcdcd;
+@border-default: 1px solid #ccc;
+@border-color-default-hover: @progressive-hover;
 
 @input-border-color: #777;
 @input-active-color: #ccc;
diff --git a/src/themes/mediawiki/elements.less 
b/src/themes/mediawiki/elements.less
index e9b7a7a..3b38f7f 100644
--- a/src/themes/mediawiki/elements.less
+++ b/src/themes/mediawiki/elements.less
@@ -173,7 +173,7 @@
                        & > .oo-ui-buttonElement-button {
                                color: @color-default;
                                background-color: @background-color-default;
-                               border: @border-button-neutral;
+                               border: @border-default;
 
                                &:hover {
                                        background-color: darken( 
@background-color-default, 8% );
diff --git a/src/themes/mediawiki/tools.less b/src/themes/mediawiki/tools.less
index d194ab5..cdf6450 100644
--- a/src/themes/mediawiki/tools.less
+++ b/src/themes/mediawiki/tools.less
@@ -282,7 +282,7 @@
        .oo-ui-toolGroup-tools {
                top: 3.125em;
                margin: 0 -1px;
-               border: 1px solid #ccc;
+               border: @border-default;
                background-color: @oo-ui-toolbar-normal;
                box-shadow: 0 2px 3px rgba( 0, 0, 0, 0.2 );
                min-width: 16em;
diff --git a/src/themes/mediawiki/widgets.less 
b/src/themes/mediawiki/widgets.less
index 8dac9ad..f40ab4a 100644
--- a/src/themes/mediawiki/widgets.less
+++ b/src/themes/mediawiki/widgets.less
@@ -108,7 +108,7 @@
                padding: 0.5em 0;
                height: 2.275em;
                line-height: 1.275;
-               border: 1px solid #ccc;
+               border: @border-default;
                border-radius: @border-radius-default;
 
                .oo-ui-indicatorElement-indicator {
@@ -187,7 +187,7 @@
        &-info {
                height: 2.4em;
                background-color: @background-color-default;
-               border: 1px solid #ccc;
+               border: @border-default;
                border-radius: @border-radius-default;
 
                > .oo-ui-indicatorElement-indicator {
@@ -433,7 +433,7 @@
                font-size: inherit;
                font-family: inherit;
                .oo-ui-box-sizing(border-box);
-               border: 1px solid #ccc;
+               border: @border-default;
                border-radius: @border-radius-default;
                padding-left: 1em;
                vertical-align: middle;
@@ -558,7 +558,7 @@
                font-family: inherit;
                background-color: @background-color-default;
                color: @color-emphasized;
-               border: 1px solid #ccc;
+               border: @border-default;
                box-shadow: inset 0 0 0 0 @progressive;
                border-radius: @border-radius-default;
                .oo-ui-transition( box-shadow @transition-ease-quick );
@@ -576,13 +576,15 @@
                                border @transition-ease-out-sine-medium,
                                box-shadow @transition-ease-out-sine-medium
                        );
-               }
 
-               input:focus,
-               textarea:focus {
-                       outline: none;
-                       border-color: @progressive;
-                       box-shadow: inset 0 0 0 0.1em @progressive;
+                       &:hover {
+                               border-color: @border-color-default-hover;
+                       }
+                       &:focus {
+                               outline: none;
+                               border-color: @progressive;
+                               box-shadow: inset 0 0 0 0.1em @progressive;
+                       }
                }
 
                input[readonly],
@@ -701,7 +703,7 @@
                .oo-ui-inline-spacing(0.5em);
 
                padding: 0.15em 0.25em;
-               border: 1px solid #ccc;
+               border: @border-default;
                border-radius: @border-radius-default;
 
                .oo-ui-box-sizing(border-box);
@@ -788,8 +790,8 @@
        line-height: 1.7em;
 
        background-color: #eee;
-       border: 1px solid #ccc;
        color: @color-default;
+       border: @border-default;
        border-radius: @border-radius-default;
 
        &.oo-ui-indicatorElement {
@@ -1109,7 +1111,7 @@
        &-query {
                height: 4em;
                padding: 0 1em;
-               border-bottom: 1px solid #ccc;
+               border-bottom: @border-default;
 
                .oo-ui-textInputWidget {
                        margin: 0.75em 0;
@@ -1303,7 +1305,7 @@
 .theme-oo-ui-progressBarWidget () {
        max-width: 50em;
        background-color: @background-color-default;
-       border: 1px solid #ccc;
+       border: @border-default;
        border-radius: @border-radius-default;
        overflow: hidden;
 

-- 
To view, visit https://gerrit.wikimedia.org/r/264581
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic850297a47e64c015d070be5cb012c57df6d58d5
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: VolkerE <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to