Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/264737
Change subject: Clean up include/require usage
......................................................................
Clean up include/require usage
For consistency across our code base.
Change-Id: I67ad1e21f170a0b22575877cbd00556c1428e0c5
---
M WikimediaBadges.php
1 file changed, 3 insertions(+), 3 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikimediaBadges
refs/changes/37/264737/1
diff --git a/WikimediaBadges.php b/WikimediaBadges.php
index 03c96ed..77402aa 100644
--- a/WikimediaBadges.php
+++ b/WikimediaBadges.php
@@ -25,8 +25,8 @@
define( 'WIKIMEDIA_BADGES_VERSION', '0.1 alpha' );
// This is the path to the autoloader generated by composer in case of a
composer install.
-if ( file_exists( __DIR__ . '/vendor/autoload.php' ) ) {
- include_once( __DIR__ . '/vendor/autoload.php' );
+if ( is_readable( __DIR__ . '/vendor/autoload.php' ) ) {
+ require_once __DIR__ . '/vendor/autoload.php';
}
$GLOBALS['wgMessagesDirs']['WikimediaBadges'] = __DIR__ . '/i18n';
@@ -48,6 +48,6 @@
$wgHooks['BeforePageDisplay'][] =
'WikimediaBadges\Hooks::onBeforePageDisplay';
// Resource Loader modules
- $wgResourceModules = array_merge( $wgResourceModules, include( __DIR__
. '/resources/Resources.php' ) );
+ $wgResourceModules = array_merge( $wgResourceModules, include __DIR__ .
'/resources/Resources.php' );
};
--
To view, visit https://gerrit.wikimedia.org/r/264737
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I67ad1e21f170a0b22575877cbd00556c1428e0c5
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikimediaBadges
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
