jenkins-bot has submitted this change and it was merged.
Change subject: Don't blur talk icon echo notifications
......................................................................
Don't blur talk icon echo notifications
Keep padding around the icon at 0.5em on the left and 1em
on the right for now; we'll change this soon to make the
icon centered.
Bug: T123656
Change-Id: I8c04daee460dd72e2358c3aa315110e05a9a5312
---
M modules/ooui/styles/mw.echo.ui.NotificationGroupItemWidget.less
M modules/ooui/styles/mw.echo.ui.NotificationItemWidget.less
2 files changed, 5 insertions(+), 5 deletions(-)
Approvals:
Mooeypoo: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ooui/styles/mw.echo.ui.NotificationGroupItemWidget.less
b/modules/ooui/styles/mw.echo.ui.NotificationGroupItemWidget.less
index 7bc589d..8cdc1f2 100644
--- a/modules/ooui/styles/mw.echo.ui.NotificationGroupItemWidget.less
+++ b/modules/ooui/styles/mw.echo.ui.NotificationGroupItemWidget.less
@@ -13,7 +13,7 @@
&-content {
margin-bottom: 0.5em;
padding-right: 0.5em;
- padding-left: 4em; // 3.5em from ItemWidget + 0.5em
+ padding-left: ~"calc(30px + 1.5em)"; // 30px+1em from
ItemWidget, plus 0.5em
}
}
diff --git a/modules/ooui/styles/mw.echo.ui.NotificationItemWidget.less
b/modules/ooui/styles/mw.echo.ui.NotificationItemWidget.less
index 7325428..50bcb71 100644
--- a/modules/ooui/styles/mw.echo.ui.NotificationItemWidget.less
+++ b/modules/ooui/styles/mw.echo.ui.NotificationItemWidget.less
@@ -24,8 +24,8 @@
&-icon {
img {
- height: 2.5em;
- width: 2.5em;
+ height: 30px;
+ width: 30px;
}
position: absolute;
@@ -33,8 +33,8 @@
&-content {
display: inline-block;
- // The icon is 2.5em and has a 1em right margin
- padding-left: 2.5em + 1em;
+ // The icon is 30px and has a 1em right margin
+ padding-left: ~"calc(30px + 1em)";
box-sizing: border-box;
width: 100%;
--
To view, visit https://gerrit.wikimedia.org/r/264564
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8c04daee460dd72e2358c3aa315110e05a9a5312
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: master
Gerrit-Owner: MtDu <justin.d...@gmail.com>
Gerrit-Reviewer: Catrope <roan.katt...@gmail.com>
Gerrit-Reviewer: Eranroz <eranro...@gmail.com>
Gerrit-Reviewer: Mooeypoo <mor...@gmail.com>
Gerrit-Reviewer: MtDu <justin.d...@gmail.com>
Gerrit-Reviewer: Pginer <pgi...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
