Niedzielski has uploaded a new change for review.
https://gerrit.wikimedia.org/r/265140
Change subject: Hygiene: replace attribute with style
......................................................................
Hygiene: replace attribute with style
Replace android:inputType="textVisiblePassword" attributes with new
style, DataStringPreference, for magic strings in the dev settings.
Change-Id: I68dd928fbef9e673c564fa4fa49bfedf4a3e81f2
---
M app/src/main/res/values/styles.xml
M app/src/main/res/xml/developer_preferences.xml
2 files changed, 12 insertions(+), 12 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia
refs/changes/40/265140/1
diff --git a/app/src/main/res/values/styles.xml
b/app/src/main/res/values/styles.xml
index c82820a..6c84387 100644
--- a/app/src/main/res/values/styles.xml
+++ b/app/src/main/res/values/styles.xml
@@ -163,6 +163,10 @@
<!--
parent="@android:style/Preference.DialogPreference.EditTextPreference" is not
exposed. -->
</style>
+ <style name="DataStringPreference"
parent="EditTextAutoSummarizePreference">
+ <item name="android:inputType">textVisiblePassword</item>
+ </style>
+
<style name="LongPreference" parent="EditTextAutoSummarizePreference">
<item name="android:inputType">number</item>
<item name="android:maxLength">20</item>
diff --git a/app/src/main/res/xml/developer_preferences.xml
b/app/src/main/res/xml/developer_preferences.xml
index 6f2fcae..a0f0165 100644
--- a/app/src/main/res/xml/developer_preferences.xml
+++ b/app/src/main/res/xml/developer_preferences.xml
@@ -33,15 +33,14 @@
<!--suppress AndroidUnknownAttribute -->
<org.wikipedia.settings.EditTextAutoSummarizePreference
- style="@style/EditTextAutoSummarizePreference"
+ style="@style/DataStringPreference"
android:key="@string/preference_key_restbase_uri_format"
android:title="@string/preference_key_restbase_uri_format"
android:dialogMessage="Prod: %1$s://%2$s/api/rest_v1
\nDev: http://host:6927/%2$s/v1
\n%1$s ➛ protocol (https if omitted)
\n%2$s ➛ WP domain
- \nNote: change requires restart."
- android:inputType="textVisiblePassword" />
+ \nNote: change requires restart." />
</PreferenceCategory>
@@ -95,10 +94,9 @@
<!--suppress AndroidUnknownAttribute -->
<org.wikipedia.settings.EditTextAutoSummarizePreference
- style="@style/EditTextAutoSummarizePreference"
+ style="@style/DataStringPreference"
android:key="@string/preference_key_reading_app_install_id"
- android:title="@string/preference_key_reading_app_install_id"
- android:inputType="textVisiblePassword" />
+ android:title="@string/preference_key_reading_app_install_id" />
<!--suppress AndroidUnknownAttribute -->
<org.wikipedia.settings.IntPreference
@@ -108,17 +106,15 @@
<!--suppress AndroidUnknownAttribute -->
<org.wikipedia.settings.EditTextAutoSummarizePreference
- style="@style/EditTextAutoSummarizePreference"
+ style="@style/DataStringPreference"
android:key="@string/preference_key_language"
- android:title="@string/preference_key_language"
- android:inputType="textVisiblePassword" />
+ android:title="@string/preference_key_language" />
<!--suppress AndroidUnknownAttribute -->
<org.wikipedia.settings.EditTextAutoSummarizePreference
- style="@style/EditTextAutoSummarizePreference"
+ style="@style/DataStringPreference"
android:key="@string/preference_key_language_mru"
- android:title="@string/preference_key_language_mru"
- android:inputType="textVisiblePassword" />
+ android:title="@string/preference_key_language_mru" />
<!-- TODO: expose in wildcard preference. -->
<!--suppress AndroidUnknownAttribute -->
--
To view, visit https://gerrit.wikimedia.org/r/265140
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I68dd928fbef9e673c564fa4fa49bfedf4a3e81f2
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Niedzielski <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
