Ori.livneh has submitted this change and it was merged. Change subject: bug 43550: return failures from validate ......................................................................
bug 43550: return failures from validate Replace $.each with a for-in so that failure returns actually return. The validate tests in tests/ext.eventLogging.tests.js didn't catch this because they monkey-patch warn to throw. Change-Id: I1437b6e88283c2e0b4ab0b182eb7db257d4a94fe --- M modules/ext.eventLogging.core.js 1 file changed, 15 insertions(+), 6 deletions(-) Approvals: Ori.livneh: Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/41826 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1437b6e88283c2e0b4ab0b182eb7db257d4a94fe Gerrit-PatchSet: 5 Gerrit-Project: mediawiki/extensions/EventLogging Gerrit-Branch: master Gerrit-Owner: Spage <[email protected]> Gerrit-Reviewer: Mattflaschen <[email protected]> Gerrit-Reviewer: Ori.livneh <[email protected]> Gerrit-Reviewer: Spage <[email protected]> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
