Lucie Kaffee has uploaded a new change for review.
https://gerrit.wikimedia.org/r/265277
Change subject: Prefix Lua module names
......................................................................
Prefix Lua module names
Bug: T120373
Change-Id: I3610e548a0bf4e3a1716433b5350887e8399bc55
---
M includes/Hooks.php
R includes/Lua/ArticlePlaceholderEntityRenderer.lua
M includes/Lua/Scribunto_LuaArticlePlaceholderLibrary.php
M includes/Template/aboutTopic-template-module.xml
4 files changed, 3 insertions(+), 3 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ArticlePlaceholder
refs/changes/77/265277/1
diff --git a/includes/Hooks.php b/includes/Hooks.php
index c8f40f2..70f1c44 100644
--- a/includes/Hooks.php
+++ b/includes/Hooks.php
@@ -23,7 +23,7 @@
array &$extraLibraries
) {
if ( $engine === 'lua' ) {
- $extraLibraries['EntityRenderer'] = array(
+ $extraLibraries['ArticlePlaceholderEntityRenderer'] =
array(
'class' =>
'ArticlePlaceholder\Lua\Scribunto_LuaArticlePlaceholderLibrary',
'deferLoad' => true,
);
diff --git a/includes/Lua/EntityRenderer.lua
b/includes/Lua/ArticlePlaceholderEntityRenderer.lua
similarity index 100%
rename from includes/Lua/EntityRenderer.lua
rename to includes/Lua/ArticlePlaceholderEntityRenderer.lua
diff --git a/includes/Lua/Scribunto_LuaArticlePlaceholderLibrary.php
b/includes/Lua/Scribunto_LuaArticlePlaceholderLibrary.php
index e1970c1..15ac2e4 100644
--- a/includes/Lua/Scribunto_LuaArticlePlaceholderLibrary.php
+++ b/includes/Lua/Scribunto_LuaArticlePlaceholderLibrary.php
@@ -39,7 +39,7 @@
);
return $this->getEngine()->registerInterface(
- __DIR__ . '/EntityRenderer.lua', $lib, array()
+ __DIR__ . '/ArticlePlaceholderEntityRenderer.lua',
$lib, array()
);
}
}
diff --git a/includes/Template/aboutTopic-template-module.xml
b/includes/Template/aboutTopic-template-module.xml
index afc2477..4efc581 100644
--- a/includes/Template/aboutTopic-template-module.xml
+++ b/includes/Template/aboutTopic-template-module.xml
@@ -49,7 +49,7 @@
-- get the label of the local entity
p.showData = function(frame)
- entityRenderer = require( 'EntityRenderer' )
+ entityRenderer = require( 'ArticlePlaceholderEntityRenderer' )
return entityRenderer.render( frame )
end
--
To view, visit https://gerrit.wikimedia.org/r/265277
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3610e548a0bf4e3a1716433b5350887e8399bc55
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ArticlePlaceholder
Gerrit-Branch: master
Gerrit-Owner: Lucie Kaffee <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits