jenkins-bot has submitted this change and it was merged.
Change subject: Do not raise a PHP warning when session write fails
......................................................................
Do not raise a PHP warning when session write fails
Bug: T124126
Change-Id: I3482d8dba4a4d9fe92a39439df41c0e70bfef35d
---
M includes/session/PHPSessionHandler.php
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Anomie: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/session/PHPSessionHandler.php
b/includes/session/PHPSessionHandler.php
index 44d14cd..5344321 100644
--- a/includes/session/PHPSessionHandler.php
+++ b/includes/session/PHPSessionHandler.php
@@ -238,10 +238,12 @@
$session = $this->manager->getSessionById( $id, true );
if ( !$session ) {
+ // This can happen under normal circumstances, if the
session exists but is
+ // invalid. Let's emit a log warning instead of a PHP
warning.
$this->logger->warning(
__METHOD__ . ": Session \"$id\" cannot be
loaded, skipping write."
);
- return false;
+ return true;
}
// First, decode the string PHP handed us
--
To view, visit https://gerrit.wikimedia.org/r/265480
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3482d8dba4a4d9fe92a39439df41c0e70bfef35d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Gergő Tisza <[email protected]>
Gerrit-Reviewer: Anomie <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
