Tchanders has uploaded a new change for review.
https://gerrit.wikimedia.org/r/265765
Change subject: Add method for setting minimum number of rows in Ace editor
widget
......................................................................
Add method for setting minimum number of rows in Ace editor widget
Bug: T123891
Change-Id: Ia2e094071f385628449f1935f0250cbeb75196f0
---
M modules/ve-mw/ui/widgets/ve.ui.MWAceEditorWidget.js
1 file changed, 16 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/65/265765/1
diff --git a/modules/ve-mw/ui/widgets/ve.ui.MWAceEditorWidget.js
b/modules/ve-mw/ui/widgets/ve.ui.MWAceEditorWidget.js
index 2e7d898..72ce4f6 100644
--- a/modules/ve-mw/ui/widgets/ve.ui.MWAceEditorWidget.js
+++ b/modules/ve-mw/ui/widgets/ve.ui.MWAceEditorWidget.js
@@ -159,6 +159,22 @@
};
/**
+ * Set the minimum number of rows in the Ace editor widget
+ *
+ * @param {number} minRows The minimum number of rows
+ */
+ve.ui.MWAceEditorWidget.prototype.setMinRows = function ( minRows ) {
+ var widget = this;
+ this.loadingPromise.done( function () {
+ widget.editor.setOptions( {
+ minLines: minRows
+ } );
+ } );
+ // TODO: Implement minRows setter for OO.ui.TextInputWidget
+ // and call it here in loadingPromise.fail
+};
+
+/**
* @inheritdoc
*/
ve.ui.MWAceEditorWidget.prototype.getRange = function () {
--
To view, visit https://gerrit.wikimedia.org/r/265765
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia2e094071f385628449f1935f0250cbeb75196f0
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Tchanders <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
