[MediaWiki-commits] [Gerrit] Remove begin()/commit() calls that can break outer transactions - change (mediawiki...QuizGame)

[Aaron Schulz (Code Review)]

Aaron Schulz has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/265842

Change subject: Remove begin()/commit() calls that can break outer transactions
......................................................................

Remove begin()/commit() calls that can break outer transactions

The single statements are already atomic and will commit at
the end of the request in commitMasterChanges().

Bug: T120791
Change-Id: Id91bb586a4f7589e4b59ee23d78c3cf4844d9d15
---
M QuestionGameHome.body.php
M api/ApiQuizGame.php
M api/ApiQuizGameVote.php
3 files changed, 0 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/QuizGame 
refs/changes/42/265842/1

diff --git a/QuestionGameHome.body.php b/QuestionGameHome.body.php
index ba67d8f..28607d5 100644
--- a/QuestionGameHome.body.php
+++ b/QuestionGameHome.body.php
@@ -1303,7 +1303,6 @@
                                        ),
                                        __METHOD__
                                );
-                               $dbw->commit( __METHOD__ );
                        }
                }
 
diff --git a/api/ApiQuizGame.php b/api/ApiQuizGame.php
index 50142bb..493c9ba 100644
--- a/api/ApiQuizGame.php
+++ b/api/ApiQuizGame.php
@@ -55,7 +55,6 @@
                                        array( 'q_id' => intval( $id ) ),
                                        __METHOD__
                                );
-                               $dbw->commit( __METHOD__ );
 
                                $output = wfMessage( 
'quizgame-ajax-unprotected' )->text();
 
@@ -72,7 +71,6 @@
                                        array( 'q_id' => intval( $id ) ),
                                        __METHOD__
                                );
-                               $dbw->commit( __METHOD__ );
 
                                $output = wfMessage( 'quizgame-ajax-protected' 
)->text();
 
@@ -106,7 +104,6 @@
                                        array( 'q_id' => intval( $id ) ),
                                        __METHOD__
                                );
-                               $dbw->commit( __METHOD__ );
 
                                $output = wfMessage( 'quizgame-ajax-unflagged' 
)->text();
 
@@ -147,7 +144,6 @@
                                        array( 'q_id' => intval( $id ) ),
                                        __METHOD__
                                );
-                               $dbw->commit( __METHOD__ );
 
                                $output = wfMessage( 'quizgame-ajax-flagged' 
)->text();
 
@@ -212,21 +208,18 @@
                                        array( 'a_q_id' => intval( $id ) ),
                                        __METHOD__
                                );
-                               $dbw->commit( __METHOD__ );
 
                                $dbw->delete(
                                        'quizgame_choice',
                                        array( 'choice_q_id' => intval( $id ) ),
                                        __METHOD__
                                );
-                               $dbw->commit( __METHOD__ );
 
                                $dbw->delete(
                                        'quizgame_questions',
                                        array( 'q_id' => intval( $id ) ),
                                        __METHOD__
                                );
-                               $dbw->commit( __METHOD__ );
 
                                $output = wfMessage( 'quizgame-ajax-deleted' 
)->text();
 
diff --git a/api/ApiQuizGameVote.php b/api/ApiQuizGameVote.php
index 75ee6b3..7377208 100644
--- a/api/ApiQuizGameVote.php
+++ b/api/ApiQuizGameVote.php
@@ -81,7 +81,6 @@
                        array( 'uv_user_id' => $user->getId(), 'uv_q_id' => 
intval( $id ) ),
                        __METHOD__
                );
-               $dbw->commit( __METHOD__ );
 
                // Update answer picked
                $dbw->update(

-- 
To view, visit https://gerrit.wikimedia.org/r/265842
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id91bb586a4f7589e4b59ee23d78c3cf4844d9d15
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/QuizGame
Gerrit-Branch: master
Gerrit-Owner: Aaron Schulz <asch...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits