Glaisher has uploaded a new change for review.
https://gerrit.wikimedia.org/r/265925
Change subject: Make mediawiki.special.pageLanguage work again
......................................................................
Make mediawiki.special.pageLanguage work again
Broken with the switch to OOUI.
This also adds 'id' param to OOUI HTMLRadioField.
Change-Id: I69c5fa9830a8b8b7cd6bf3468b5600325d34c070
---
M includes/htmlform/HTMLRadioField.php
M resources/Resources.php
M resources/src/mediawiki.special/mediawiki.special.pageLanguage.js
3 files changed, 12 insertions(+), 6 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/25/265925/1
diff --git a/includes/htmlform/HTMLRadioField.php
b/includes/htmlform/HTMLRadioField.php
index 2d05704..64f9cb6 100644
--- a/includes/htmlform/HTMLRadioField.php
+++ b/includes/htmlform/HTMLRadioField.php
@@ -49,6 +49,7 @@
return new OOUI\RadioSelectInputWidget( array(
'name' => $this->mName,
+ 'id' => $this->mID,
'value' => $value,
'options' => $options,
'classes' => 'mw-htmlform-flatlist-item',
diff --git a/resources/Resources.php b/resources/Resources.php
index 18bff51..8dac08e 100644
--- a/resources/Resources.php
+++ b/resources/Resources.php
@@ -1761,6 +1761,9 @@
),
'mediawiki.special.pageLanguage' => array(
'scripts' =>
'resources/src/mediawiki.special/mediawiki.special.pageLanguage.js',
+ 'dependencies' => array(
+ 'oojs-ui',
+ ),
),
'mediawiki.special.pagesWithProp' => array(
'position' => 'top',
diff --git a/resources/src/mediawiki.special/mediawiki.special.pageLanguage.js
b/resources/src/mediawiki.special/mediawiki.special.pageLanguage.js
index 7c2269f..fa35ac1 100644
--- a/resources/src/mediawiki.special/mediawiki.special.pageLanguage.js
+++ b/resources/src/mediawiki.special/mediawiki.special.pageLanguage.js
@@ -1,9 +1,11 @@
-( function ( $ ) {
- $( document ).ready( function () {
-
+/*!
+ * JavaScript module used on Special:PageLanguage
+ */
+( function ( $, OO ) {
+ $( function () {
// Select the 'Language select' option if user is trying to
select language
- $( '#mw-pl-languageselector' ).on( 'click', function () {
- $( '#mw-pl-options-2' ).prop( 'checked', true );
+ OO.ui.infuse( 'mw-pl-languageselector' ).$element.on( 'click',
function () {
+ OO.ui.infuse( 'mw-pl-options' ).setValue( '2' );
} );
} );
-}( jQuery ) );
+}( jQuery, OO ) );
--
To view, visit https://gerrit.wikimedia.org/r/265925
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I69c5fa9830a8b8b7cd6bf3468b5600325d34c070
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Glaisher <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
