Ejegg has submitted this change and it was merged.
Change subject: Make landing page parameters case-insensitive
......................................................................
Make landing page parameters case-insensitive
Been losing a lot of email clicks due to contact_ID instead of
contact_id. Reduce cognitive load on email crafters.
Bug: T114010
Change-Id: I23bd94c2785fb946f25e21d72a24a35532312318
---
M fundraiser/analytics/management/commands/LoadLPImpressions.py
1 file changed, 3 insertions(+), 0 deletions(-)
Approvals:
Ejegg: Verified
Awight: Looks good to me, approved
diff --git a/fundraiser/analytics/management/commands/LoadLPImpressions.py
b/fundraiser/analytics/management/commands/LoadLPImpressions.py
index 1a18da2..efd8173 100644
--- a/fundraiser/analytics/management/commands/LoadLPImpressions.py
+++ b/fundraiser/analytics/management/commands/LoadLPImpressions.py
@@ -240,6 +240,9 @@
# go ahead and parse the URL
url = urlparse.urlparse(url_uni)
qs = urlparse.parse_qs(url.query,
keep_blank_values=True)
+ # convert parameter names to lowercase
+ for p in qs:
+ qs[p.lower] = qs[p]
# grab the tracking information that should be common
to any LP
utm_source = ""
--
To view, visit https://gerrit.wikimedia.org/r/263679
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I23bd94c2785fb946f25e21d72a24a35532312318
Gerrit-PatchSet: 1
Gerrit-Project: wikimedia/fundraising/tools/DjangoBannerStats
Gerrit-Branch: master
Gerrit-Owner: Ejegg <[email protected]>
Gerrit-Reviewer: Awight <[email protected]>
Gerrit-Reviewer: Ejegg <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
