Tinaj1234 has uploaded a new change for review.
https://gerrit.wikimedia.org/r/266049
Change subject: Add minimum length for description field
......................................................................
Add minimum length for description field
To avoid one word or very short descriptions for newsletters, added
a test to check if the text is atleast 30 characters.
Bug: T110491
Change-Id: I82d8645b652a79854d836dc7cbd4741ed7d44526
---
M i18n/en.json
M i18n/qqq.json
M includes/specials/SpecialNewsletterCreate.php
3 files changed, 6 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Newsletter
refs/changes/49/266049/1
diff --git a/i18n/en.json b/i18n/en.json
index 007a6ad..ced66c7 100755
--- a/i18n/en.json
+++ b/i18n/en.json
@@ -22,6 +22,7 @@
"newsletter-create-submit": "Create newsletter",
"newsletter-create-confirmation": "A new newsletter has been
successfully created. You can manage newsletters through
[[Special:ManageNewsletter]].",
"newsletter-create-mainpage-error": "Invalid newsletter main page
entered. Please try again.",
+ "newsletter-create-short-description-error": "The description is too
short.",
"newsletter-subtitlelinks-list": "List of newsletters",
"newsletter-subtitlelinks-create": "Create a new newsletter",
"newsletter-subtitlelinks-manage": "Manage newsletter",
diff --git a/i18n/qqq.json b/i18n/qqq.json
index 775d00a..47a6bfc 100644
--- a/i18n/qqq.json
+++ b/i18n/qqq.json
@@ -26,6 +26,7 @@
"newsletter-create-submit": "Label of submit button on
[[Special:CreateNewsletter]]",
"newsletter-create-confirmation": "Confirmation message displayed after
creation of a newsletter",
"newsletter-create-mainpage-error": "Error message shown on
[[Special:CreateNewsletter]] if the page entered on main page field does not
exist.",
+ "newsletter-create-short-description-error": "Error message shown on
[[Special:CreateNewsletter]] if the text entered in the description field is
too short.",
"newsletter-subtitlelinks-list": "Label for link to
[[Special:Newsletters]] shown under the header on Newsletter special
pages.\n\nSee also:\n*
{{msg-mw|newsletter-subtitlelinks-create}}\n*{{msg-mw|newsletter-subtitlelinks-manage}}",
"newsletter-subtitlelinks-create": "Label for link to
[[Special:CreateNewsletter]] shown under the header on Newsletter special
pages.\n\nSee also:\n*
{{msg-mw|newsletter-subtitlelinks-list}}\n*{{msg-mw|newsletter-subtitlelinks-manage}}",
"newsletter-subtitlelinks-manage": "Label for link to
[[Special:ManageNewsletter]] shown under the header on Newsletter special
pages.\n\nSee also:\n*
{{msg-mw|newsletter-subtitlelinks-create}}\n*{{msg-mw|newsletter-subtitlelinks-list}}",
diff --git a/includes/specials/SpecialNewsletterCreate.php
b/includes/specials/SpecialNewsletterCreate.php
index 9c4f0fd..6e97d23 100644
--- a/includes/specials/SpecialNewsletterCreate.php
+++ b/includes/specials/SpecialNewsletterCreate.php
@@ -84,6 +84,10 @@
( $articleId !== 0 ) &&
isset( $data['mainpage'] )
) {
+ if ( strlen($data['description'] ) < 30 ) {
+ return array(
'newsletter-create-short-description-error' );
+ }
+
$db = NewsletterDb::newFromGlobalState();
// nl_newsletters.nl_desc is a blob but put some limit
--
To view, visit https://gerrit.wikimedia.org/r/266049
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I82d8645b652a79854d836dc7cbd4741ed7d44526
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Newsletter
Gerrit-Branch: master
Gerrit-Owner: Tinaj1234 <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
