Nikerabbit has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/266221

Change subject: Remove multiple unused messages and make some grepable
......................................................................

Remove multiple unused messages and make some grepable

Change-Id: Ib18160290cab7c311c93900fb659337c2ec879f2
---
M Translate.php
M TranslateHooks.php
M i18n/core/en.json
M i18n/pagetranslation/en.json
M i18n/search/en.json
M specials/SpecialManageGroups.php
M specials/SpecialPageMigration.php
M specials/SpecialSupportedLanguages.php
M specials/SpecialTranslations.php
M tag/PageTranslationLogFormatter.php
M utils/TranslateSandbox.php
M utils/UserToggles.php
12 files changed, 44 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Translate 
refs/changes/21/266221/1

diff --git a/Translate.php b/Translate.php
index 3d4f559..111ab65 100644
--- a/Translate.php
+++ b/Translate.php
@@ -182,21 +182,32 @@
 $wgHooks['DeleteAccount'][] = 'TranslateHooks::onDeleteAccount';
 
 // New rights
+// right-translate
 $wgAvailableRights[] = 'translate';
+// right-translate-import action-translate-import
 $wgAvailableRights[] = 'translate-import';
+// right-translate-manage action-translate-manage
 $wgAvailableRights[] = 'translate-manage';
+// right-translate-messagereview
 $wgAvailableRights[] = 'translate-messagereview';
+// right-translate-groupreview
 $wgAvailableRights[] = 'translate-groupreview';
+// right-translate-sandboxmanage action-translate-sandboxmanage
 $wgAvailableRights[] = 'translate-sandboxmanage';
 
 // Logs. More logs are defined in TranslateHooks::setupTranslate
+// log-name-translationreview log-descriptionmsg-translationreview
 $wgLogTypes[] = 'translationreview';
+// logentry-translationreview-message logentry-translationreview-group
 $wgLogActionsHandlers['translationreview/message'] = 'TranslateLogFormatter';
 $wgLogActionsHandlers['translationreview/group'] = 'TranslateLogFormatter';
 
+// log-name-translatorsandbox log-description-translatorsandbox
 $wgLogTypes[] = 'translatorsandbox';
+// logentry-translatorsandbox-promoted logentry-translatorsandbox-rejected
 $wgLogActionsHandlers['translatorsandbox/promoted'] = 'TranslateLogFormatter';
 $wgLogActionsHandlers['translatorsandbox/rejected'] = 'TranslateLogFormatter';
+// logentry-newusers-tsbpromoted
 $wgLogActionsHandlers['newusers/tsbpromoted'] = 'LogFormatter';
 
 // New jobs
diff --git a/TranslateHooks.php b/TranslateHooks.php
index fcc671a..a2d1a6c 100644
--- a/TranslateHooks.php
+++ b/TranslateHooks.php
@@ -68,12 +68,21 @@
                        $wgSpecialPages['PageTranslation'] = 
'SpecialPageTranslation';
                        $wgSpecialPages['PageTranslationDeletePage'] = 
'SpecialPageTranslationDeletePage';
 
+                       // right-pagetranslation action-pagetranslation
                        $wgAvailableRights[] = 'pagetranslation';
 
                        $wgSpecialPages['PageMigration'] = 
'SpecialPageMigration';
                        $wgSpecialPages['PagePreparation'] = 
'SpecialPagePreparation';
 
                        global $wgLogActionsHandlers, $wgLogTypes;
+
+                       // log-description-pagetranslation 
log-name-pagetranslation logentry-pagetranslation-mark
+                       // logentry-pagetranslation-unmark 
logentry-pagetranslation-moveok
+                       // logentry-pagetranslation-movenok 
logentry-pagetranslation-deletefok
+                       // logentry-pagetranslation-deletefnok 
logentry-pagetranslation-deletelok
+                       // logentry-pagetranslation-deletelnok 
logentry-pagetranslation-encourage
+                       // logentry-pagetranslation-discourage 
logentry-pagetranslation-prioritylanguages
+                       // logentry-pagetranslation-associate 
logentry-pagetranslation-dissociate
                        $wgLogTypes[] = 'pagetranslation';
                        $wgLogActionsHandlers['pagetranslation/mark'] = 
'PageTranslationLogFormatter';
                        $wgLogActionsHandlers['pagetranslation/unmark'] = 
'PageTranslationLogFormatter';
diff --git a/i18n/core/en.json b/i18n/core/en.json
index 75f0b4e..2b67253 100644
--- a/i18n/core/en.json
+++ b/i18n/core/en.json
@@ -36,7 +36,6 @@
        "translate-page-navigation-legend": "Navigation",
        "translate-page-showing": "Showing messages from $1 to $2 of $3.",
        "translate-page-showing-all": "Showing $1 
{{PLURAL:$1|message|messages}}.",
-       "translate-page-showing-none": "No messages to show.",
        "translate-page-paging-links": "[ $1 ] [ $2 ]",
        "translate-next": "Next page",
        "translate-prev": "Previous page",
@@ -270,8 +269,6 @@
        "translate-messagereview-no-fuzzy": "Fuzzy translations cannot be 
marked as reviewed.",
        "translate-messagereview-no-own": "You cannot mark your own 
translations as reviewed.",
        "translate-messagereview-doit": "Mark this translation as reviewed.",
-       "group-translate-proofr.css": "/* CSS placed here will affect 
translation reviewers only */",
-       "group-translate-proofr.js": "/* JS placed here will affect translation 
reviewer only */",
        "log-name-translationreview": "Translation review log",
        "log-description-translationreview": "Log of all reviews to 
translations and message groups.",
        "logentry-translationreview-message": "$1 {{GENDER:$2|reviewed}} 
translation $3",
diff --git a/i18n/pagetranslation/en.json b/i18n/pagetranslation/en.json
index 106c3d2..24204c7 100644
--- a/i18n/pagetranslation/en.json
+++ b/i18n/pagetranslation/en.json
@@ -8,12 +8,9 @@
        "pagetranslation": "Page translation",
        "right-pagetranslation": "Mark versions of pages for translation",
        "action-pagetranslation": "manage translatable pages",
-       "tpt-desc": "Extension for translating content pages",
        "tpt-section": "Translation unit $1",
        "tpt-section-new": "New translation unit.\nName: $1",
        "tpt-section-deleted": "Translation unit $1",
-       "tpt-template": "Page template",
-       "tpt-templatediff": "The page template has changed.",
        "tpt-diff-old": "Previous text",
        "tpt-diff-new": "New text",
        "tpt-submit": "Mark this version for translation",
@@ -27,7 +24,6 @@
        "tpt-notsuitable": "Page $1 is not suitable for translation.\nMake sure 
it has <nowiki><translate></nowiki> tags and has a valid syntax.",
        "tpt-saveok": "The page [[:$1]] has been marked up for translation with 
$2 {{PLURAL:$2|translation unit|translation units}}.\nThe page can now be <span 
class=\"plainlinks\">[$3 translated]</span>.",
        "tpt-offer-notify": "You can <span class=\"plainlinks\">[$1 notify 
translators]</span> about this page.",
-       "tpt-badsect": "\"$1\" is not a valid name for translation unit $2.",
        "tpt-showpage-intro": "Below new, existing and deleted translation 
units are listed.\nBefore marking this version for translation, check that the 
changes to translation units are minimized to avoid unnecessary work for 
translators.",
        "tpt-mark-summary": "Marked this version for translation",
        "tpt-mark-nochanges": "No changes to review. Marking this page for 
translation will not edit the page nor any existing translation unit.",
@@ -79,7 +75,6 @@
        "tpt-discouraged-language-reason": "Reason: $1",
        "tpt-priority-languages": "A translation administrator has set the 
priority languages for this group to $1.",
        "tpt-render-summary": "Updating to match new version of source page",
-       "tpt-download-page": "Export page with translations",
        "aggregategroups": "Aggregate groups",
        "tpt-aggregategroup-add": "Add",
        "tpt-aggregategroup-save": "Save",
diff --git a/i18n/search/en.json b/i18n/search/en.json
index 3f0b64f..dc6eced 100644
--- a/i18n/search/en.json
+++ b/i18n/search/en.json
@@ -12,7 +12,6 @@
        "tux-sst-count": "{{PLURAL:$1|One result found|$1 results found}}",
        "tux-sst-facet-language": "Languages",
        "tux-sst-facet-group": "Message groups",
-       "tux-sst-facet-orphan": "(orphan)",
        "tux-sst-nosolr-title": "Search unavailable",
        "tux-sst-nosolr-body": "This wiki does not have a translation search 
service.",
        "tux-sst-solr-offline-title": "Search unavailable",
diff --git a/specials/SpecialManageGroups.php b/specials/SpecialManageGroups.php
index e07c5d8..85ea3d4 100644
--- a/specials/SpecialManageGroups.php
+++ b/specials/SpecialManageGroups.php
@@ -40,6 +40,10 @@
                return 'wiki';
        }
 
+       function getDescription() {
+               return $this->msg( 'managemessagegroups' )->text();
+       }
+
        public function execute( $par ) {
                $this->setHeaders();
                $out = $this->getOutput();
diff --git a/specials/SpecialPageMigration.php 
b/specials/SpecialPageMigration.php
index 6a5a761..6ef4323 100644
--- a/specials/SpecialPageMigration.php
+++ b/specials/SpecialPageMigration.php
@@ -17,11 +17,16 @@
                return 'wiki';
        }
 
+       function getDescription() {
+               return $this->msg( 'pagemigration' )->text();
+       }
+
        function execute( $par ) {
                $request = $this->getRequest();
                $output = $this->getOutput();
                $this->setHeaders();
                $this->checkPermissions();
+               $this->outputHeader( 'pagemigration-summary' );
                $output->addModules( 'ext.translate.special.pagemigration' );
                $output->addModuleStyles( 'jquery.uls.grid' );
                # Get request data from, e.g.
diff --git a/specials/SpecialSupportedLanguages.php 
b/specials/SpecialSupportedLanguages.php
index 6da2c8f..c06fb9e 100644
--- a/specials/SpecialSupportedLanguages.php
+++ b/specials/SpecialSupportedLanguages.php
@@ -33,6 +33,10 @@
                return 'wiki';
        }
 
+       function getDescription() {
+               return $this->msg( 'supportedlanguages' )->text();
+       }
+
        public function execute( $par ) {
                $out = $this->getOutput();
                $lang = $this->getLanguage();
@@ -48,7 +52,7 @@
                        
'Help:Extension:Translate/Statistics_and_reporting#List_of_languages_and_translators'
                );
 
-               $this->outputHeader();
+               $this->outputHeader( 'supportedlanguages-summary' );
                $dbr = wfGetDB( DB_SLAVE );
                if ( $dbr->getType() === 'sqlite' ) {
                        $out->addWikiText( '<div class=errorbox>SQLite is not 
supported.</div>' );
diff --git a/specials/SpecialTranslations.php b/specials/SpecialTranslations.php
index 1d20988..a7837bf 100644
--- a/specials/SpecialTranslations.php
+++ b/specials/SpecialTranslations.php
@@ -23,6 +23,10 @@
                return 'pages';
        }
 
+       function getDescription() {
+               return $this->msg( 'translations' )->text();
+       }
+
        /**
         * Entry point : initialise variables and call subfunctions.
         * @param string $par Message key. Becomes "MediaWiki:Allmessages" when 
called like
diff --git a/tag/PageTranslationLogFormatter.php 
b/tag/PageTranslationLogFormatter.php
index 4008223..a2362c9 100644
--- a/tag/PageTranslationLogFormatter.php
+++ b/tag/PageTranslationLogFormatter.php
@@ -4,7 +4,6 @@
  *
  * @file
  * @author Niklas Laxström
- * @copyright Copyright © 2013, Niklas Laxström
  * @license GPL-2.0+
  */
 
@@ -81,6 +80,9 @@
        protected function getMessageKey() {
                $key = parent::getMessageKey();
                $type = $this->entry->getFullType();
+
+               // logentry-pagetranslation-prioritylanguages-unset
+               // logentry-pagetranslation-prioritylanguages-force
                if ( $type === 'pagetranslation/prioritylanguages' ) {
                        $params = $this->getMessageParameters();
                        if ( !isset( $params[4] ) ) {
diff --git a/utils/TranslateSandbox.php b/utils/TranslateSandbox.php
index 8bb7ed0..3c88a67 100644
--- a/utils/TranslateSandbox.php
+++ b/utils/TranslateSandbox.php
@@ -36,6 +36,7 @@
                $user->saveSettings();
 
                // Need to have an id first
+               // group-translate-sandboxed group-translate-sandboxed-member
                $user->addGroup( 'translate-sandboxed' );
                $user->clearInstanceCache( 'name' );
                $user->sendConfirmationMail();
@@ -207,6 +208,7 @@
                        return true;
                }
 
+               // right-translate-sandboxaction action-translate-sandboxaction
                $rights = array(
                        'editmyoptions',
                        'editmyprivateinfo',
diff --git a/utils/UserToggles.php b/utils/UserToggles.php
index 030a302..6a541e7 100644
--- a/utils/UserToggles.php
+++ b/utils/UserToggles.php
@@ -69,6 +69,7 @@
 
                $preferences['translate-editlangs'] = array(
                        'class' => 'HTMLJsSelectToInputField',
+                       // prefs-translate
                        'section' => 'editing/translate',
                        'label-message' => 'translate-pref-editassistlang',
                        'help-message' => 'translate-pref-editassistlang-help',

-- 
To view, visit https://gerrit.wikimedia.org/r/266221
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib18160290cab7c311c93900fb659337c2ec879f2
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: Nikerabbit <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to