Matthias Mullie has uploaded a new change for review.
https://gerrit.wikimedia.org/r/266235
Change subject: If user only has foreign messages, the messages badge should
not be suppressed
......................................................................
If user only has foreign messages, the messages badge should not be suppressed
Bug: T124372
Change-Id: Id9699c56e9b8c6af77e74cbfc48b6e4e3464b3a5
---
M Hooks.php
1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Echo
refs/changes/35/266235/1
diff --git a/Hooks.php b/Hooks.php
index afdaacf..1016634 100644
--- a/Hooks.php
+++ b/Hooks.php
@@ -753,7 +753,9 @@
'notifications-alert' => $alertLink,
);
- if ( $notifUser->hasMessages() ) {
+ // hasMessages() checks if the user has ever had (local)
messages, or if they
+ // have any currently unread message at all (including on
foreign wikis)
+ if ( $notifUser->hasMessages() || $msgCount > 0 ) {
$msgLink = array(
'href' => $url,
'text' => $msgText,
--
To view, visit https://gerrit.wikimedia.org/r/266235
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id9699c56e9b8c6af77e74cbfc48b6e4e3464b3a5
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: master
Gerrit-Owner: Matthias Mullie <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
