Jonas Kress (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/266237
Change subject: Introduce page image area in side bar with wbtooltip (help text)
......................................................................
Introduce page image area in side bar with wbtooltip (help text)
The area is still hidden and no actual help text is set.
Bug: T124044
Change-Id: I4d7242a8aac26d14a1fbaa2caadd3fa0db97bcbb
---
M view/resources/templates.php
M view/resources/wikibase/wikibase.css
M view/src/ItemView.php
3 files changed, 42 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/37/266237/1
diff --git a/view/resources/templates.php b/view/resources/templates.php
index 907ea49..86b9eda 100644
--- a/view/resources/templates.php
+++ b/view/resources/templates.php
@@ -322,5 +322,14 @@
</div>
HTML;
+ $templates['wikibase-pageimage'] =
+<<<HTML
+<div class="wikibase-pageImage">
+ <div class="help">
+ <span class="mw-help-field-hint wikibase-toolbar-item
wikibase-wbtooltip" original-title="$1"> </span>
+ </div>
+</div>
+HTML;
+
return $templates;
} );
diff --git a/view/resources/wikibase/wikibase.css
b/view/resources/wikibase/wikibase.css
index 7feed05..2e8e80b 100644
--- a/view/resources/wikibase/wikibase.css
+++ b/view/resources/wikibase/wikibase.css
@@ -660,3 +660,24 @@
border: none;
}
/***** /DIFF VIEW *****/
+
+/********** PAGE IMAGE **********/
+
+.wikibase-pageImage {
+ display: none;
+ border: 1px solid #C9C9C9;
+ position: relative;
+ width: 100%;
+}
+
+.wikibase-pageImage .help {
+ position: absolute;
+ top: 0;
+ right: 0;
+}
+
+.wikibase-pageImage .help .wikibase-wbtooltip {
+ text-decoration: none;
+}
+
+/********** /PAGEIMAGE **********/
diff --git a/view/src/ItemView.php b/view/src/ItemView.php
index dd24bae..178b80c 100644
--- a/view/src/ItemView.php
+++ b/view/src/ItemView.php
@@ -91,7 +91,9 @@
* @return string HTML
*/
protected function getSideHtml( EntityDocument $entity ) {
- return $this->getHtmlForSiteLinks( $entity );
+ return $this->getHtmlForPageImage()
+ .$this->getHtmlForSiteLinks( $entity );
+
}
/**
@@ -111,4 +113,13 @@
);
}
+ /**
+ * Builds and returns the HTML representing a WikibaseEntity's page
image.
+ *
+ * @return string
+ */
+ protected function getHtmlForPageImage() {
+ return $this->templateFactory->render( 'wikibase-pageimage' );
+ }
+
}
--
To view, visit https://gerrit.wikimedia.org/r/266237
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4d7242a8aac26d14a1fbaa2caadd3fa0db97bcbb
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Jonas Kress (WMDE) <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
