jenkins-bot has submitted this change and it was merged.
Change subject: ve.dm.Scalable: Prevent validation from exploding on bad input
......................................................................
ve.dm.Scalable: Prevent validation from exploding on bad input
Bug: T124515
Change-Id: Iaa4812974dc6130bd39ebe64e7b5fc3ca406b634
---
M src/dm/ve.dm.Scalable.js
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Esanders: Looks good to me, approved
jenkins-bot: Verified
diff --git a/src/dm/ve.dm.Scalable.js b/src/dm/ve.dm.Scalable.js
index 61abb55..ed000ae 100644
--- a/src/dm/ve.dm.Scalable.js
+++ b/src/dm/ve.dm.Scalable.js
@@ -604,6 +604,7 @@
maxDimensions = this.isEnforcedMax() && !$.isEmptyObject(
this.getMaxDimensions() ) && this.getMaxDimensions();
this.valid = (
+ !!dimensions &&
$.isNumeric( dimensions.width ) &&
$.isNumeric( dimensions.height ) &&
(
--
To view, visit https://gerrit.wikimedia.org/r/265917
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaa4812974dc6130bd39ebe64e7b5fc3ca406b634
Gerrit-PatchSet: 2
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: Esanders <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
