jenkins-bot has submitted this change and it was merged. Change subject: Set threshold for is a tablet in LESS variable ......................................................................
Set threshold for is a tablet in LESS variable We need to centrally define our definition of a tablet device so we can consistently serve alternative mobile and tablet versions. As well as the two mentioned extensions in the see section, there are also instances in Gather, Vector, Metrolook and various other extensions that will benefit from this. See I257b3b34536 and I97d9600c839. Bug: T93675 Change-Id: Iefce83763da0cbd037a7ff889088b0da820220a0 --- M includes/DefaultSettings.php 1 file changed, 9 insertions(+), 1 deletion(-) Approvals: Krinkle: Looks good to me, approved jenkins-bot: Verified diff --git a/includes/DefaultSettings.php b/includes/DefaultSettings.php index a22a29d..00a5709 100644 --- a/includes/DefaultSettings.php +++ b/includes/DefaultSettings.php @@ -3688,7 +3688,15 @@ * @endcode * @since 1.22 */ -$wgResourceLoaderLESSVars = array(); +$wgResourceLoaderLESSVars = array( + /** + * Minimum available screen width at which a device can be considered a tablet/desktop + * The number is currently based on the device width of a Samsung Galaxy S5 mini and is low + * enough to cover iPad (768px). Number is prone to change with new information. + * @since 1.27 + */ + 'deviceWidthTablet' => '720px', +); /** * Default import paths for LESS modules. LESS files referenced in @import -- To view, visit https://gerrit.wikimedia.org/r/261457 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iefce83763da0cbd037a7ff889088b0da820220a0 Gerrit-PatchSet: 12 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Jdlrobson <[email protected]> Gerrit-Reviewer: Jdlrobson <[email protected]> Gerrit-Reviewer: Krinkle <[email protected]> Gerrit-Reviewer: Legoktm <[email protected]> Gerrit-Reviewer: Phuedx <[email protected]> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
