jenkins-bot has submitted this change and it was merged. Change subject: (minor) Make ORMTable handle failed queries nicely. ......................................................................
(minor) Make ORMTable handle failed queries nicely. Database::select will return false if a query fails and the DB object is set to "ignore errors" mode. ORMTable now detect this and throw a DBQueryError, overriding the ignore errors mode. This change also adds a dummy implementation for ORMTable to ORMTableTest, so tests can be run on the base implementation. Change-Id: I5d87295626c0800c38f807d19becb312ba7cc956 --- M includes/db/IORMTable.php M includes/db/ORMTable.php M tests/phpunit/includes/db/ORMTableTest.php 3 files changed, 119 insertions(+), 9 deletions(-) Approvals: Aaron Schulz: Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/37233 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5d87295626c0800c38f807d19becb312ba7cc956 Gerrit-PatchSet: 7 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Daniel Kinzler <[email protected]> Gerrit-Reviewer: Aaron Schulz <[email protected]> Gerrit-Reviewer: Aude <[email protected]> Gerrit-Reviewer: Daniel Kinzler <[email protected]> Gerrit-Reviewer: Demon <[email protected]> Gerrit-Reviewer: Jeroen De Dauw <[email protected]> Gerrit-Reviewer: Platonides <[email protected]> Gerrit-Reviewer: Reedy <[email protected]> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
