Mforns has submitted this change and it was merged.
Change subject: Improve logging around schema fetch failure and sql_writer
finally block
......................................................................
Improve logging around schema fetch failure and sql_writer finally block
Change-Id: Ibfa4bcba53cc71f1bd078d0bc2fa74350e372260
---
M eventlogging/handlers.py
M eventlogging/schema.py
2 files changed, 5 insertions(+), 1 deletion(-)
Approvals:
Mforns: Verified; Looks good to me, approved
diff --git a/eventlogging/handlers.py b/eventlogging/handlers.py
index 6d5ad4f..dabda72 100644
--- a/eventlogging/handlers.py
+++ b/eventlogging/handlers.py
@@ -327,6 +327,10 @@
store_sql_events(meta, scid, scid_events, replace=replace)
if stats:
stats.incr('overall.inserted', len(scid_events))
+ logger.info(
+ 'Finally finished inserting remaining events '
+ 'before exiting sql handler.'
+ )
@writes('file')
diff --git a/eventlogging/schema.py b/eventlogging/schema.py
index 7331c1f..edc98c6 100644
--- a/eventlogging/schema.py
+++ b/eventlogging/schema.py
@@ -217,7 +217,7 @@
schema = yaml.load(url_get(url))
except (ValueError, EnvironmentError) as ex:
- raise SchemaError('Schema fetch failure: %s' % ex)
+ raise SchemaError('Schema fetch from %s failed: %s' % (url, ex))
# Make sure the schema itself validates.
get_validator(schema).check_schema(schema)
return schema
--
To view, visit https://gerrit.wikimedia.org/r/267070
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibfa4bcba53cc71f1bd078d0bc2fa74350e372260
Gerrit-PatchSet: 2
Gerrit-Project: eventlogging
Gerrit-Branch: master
Gerrit-Owner: Ottomata <[email protected]>
Gerrit-Reviewer: Mforns <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
