jenkins-bot has submitted this change and it was merged.
Change subject: Use boolean values for .prop() on boolean HTML attributes
......................................................................
Use boolean values for .prop() on boolean HTML attributes
.prop() expects a boolean value. .id() returns a boolean value.
Change-Id: If3dc6197f9dded92e99faeaa33e31dc937ebf66f
---
M modules/jquery.wikiEditor.publish.js
1 file changed, 2 insertions(+), 4 deletions(-)
Approvals:
TheDJ: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/jquery.wikiEditor.publish.js
b/modules/jquery.wikiEditor.publish.js
index 9903412..24b2fa3 100644
--- a/modules/jquery.wikiEditor.publish.js
+++ b/modules/jquery.wikiEditor.publish.js
@@ -116,11 +116,9 @@
buttons: {
'wikieditor-publish-dialog-publish': function () {
var
minorChecked = $( '#wikiEditor-' + context.instance +
-
'-dialog-minor' ).is( ':checked' ) ?
-
'checked' : '';
+
'-dialog-minor' ).is( ':checked' );
var
watchChecked = $( '#wikiEditor-' + context.instance +
-
'-dialog-watch' ).is( ':checked' ) ?
-
'checked' : '';
+
'-dialog-watch' ).is( ':checked' );
$(
'#wpMinoredit' ).prop( 'checked', minorChecked );
$(
'#wpWatchthis' ).prop( 'checked', watchChecked );
$(
'#wpSummary' ).val( $( '#wikiEditor-' + context.instance +
--
To view, visit https://gerrit.wikimedia.org/r/264278
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If3dc6197f9dded92e99faeaa33e31dc937ebf66f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikiEditor
Gerrit-Branch: master
Gerrit-Owner: Gerrit Patch Uploader <[email protected]>
Gerrit-Reviewer: Gerrit Patch Uploader <[email protected]>
Gerrit-Reviewer: TheDJ <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
