Aaron Schulz has uploaded a new change for review.
https://gerrit.wikimedia.org/r/267382
Change subject: Add backend response time metric split by platform
......................................................................
Add backend response time metric split by platform
This only counts server time, unlike time-to-first byte
Change-Id: Ife7603752134482dd622b4d935fa42c478a18952
---
M WikimediaEventsHooks.php
M extension.json
2 files changed, 23 insertions(+), 0 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikimediaEvents
refs/changes/82/267382/1
diff --git a/WikimediaEventsHooks.php b/WikimediaEventsHooks.php
index f5ac107..641df66 100644
--- a/WikimediaEventsHooks.php
+++ b/WikimediaEventsHooks.php
@@ -478,4 +478,24 @@
return true;
}
+
+ public static function onArticleViewHeader() {
+ DeferredUpdates::addCallableUpdate( function () {
+ $context = RequestContext::getMain();
+ $timing = $context->getTiming();
+ if ( class_exists( 'MobileContext' )
+ &&
MobileContext::singleton()->shouldDisplayMobileView()
+ ) {
+ $platform = 'mobile';
+ } else {
+ $platform = 'desktop';
+ }
+
+ $measure = $timing->measure( 'viewResponseTime',
'requestStart', 'requestShutdown' );
+ if ( $measure !== false ) {
+ $context->getStats()->timing(
+ "timing.viewResponseTime.{$platform}",
$measure['duration'] * 1000 );
+ }
+ } );
+ }
}
diff --git a/extension.json b/extension.json
index 4841f5c..c700d30 100644
--- a/extension.json
+++ b/extension.json
@@ -28,6 +28,9 @@
"ArticleUndelete": [
"WikimediaEventsHooks::onArticleUndelete"
],
+ "ArticleViewHeader": [
+ "WikimediaEventsHooks::onArticleViewHeader"
+ ],
"TitleMoveComplete": [
"WikimediaEventsHooks::onTitleMoveComplete"
],
--
To view, visit https://gerrit.wikimedia.org/r/267382
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ife7603752134482dd622b4d935fa42c478a18952
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikimediaEvents
Gerrit-Branch: master
Gerrit-Owner: Aaron Schulz <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
