Subramanya Sastry has uploaded a new change for review.
https://gerrit.wikimedia.org/r/268046
Change subject: rt-testing testreduce client: use --num-workers 0 for Parsoid
......................................................................
rt-testing testreduce client: use --num-workers 0 for Parsoid
* The RT-testing code starts a Parsoid server via apiServer.js
apiServer.js has an on-exit handler that restarts a crashed
server on the same port as before. This ensures that the testreduce
client can continue posting on the same port without needing to
know about parsoid restarts.
* Earlier, we used to spawn a cluster master (with 1 worker) which
left the restart at the discretion of server.js. In node 0.10
the workers were restarting on the same port. But, in node 4.2,
looks like the workers were restarting on a random port.
This led to testreduce clients posting to nonexisting Parsoid
servers and failing miserably.
Change-Id: I0e5d8c38a8b56382ad84e6309c741ba02e320ba2
---
M tests/apiServer.js
M tests/testreduce/rtTestWrapper.js
2 files changed, 4 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/parsoid
refs/changes/46/268046/1
diff --git a/tests/apiServer.js b/tests/apiServer.js
index 03f8c0a..2a1e811 100644
--- a/tests/apiServer.js
+++ b/tests/apiServer.js
@@ -121,7 +121,7 @@
console.warn('Restarting server at: ', url);
forkedServers.delete(url);
}
- resolve(startServer(opts));
+ startServer(opts);
});
forkedServer.child.on('message', function(m) {
diff --git a/tests/testreduce/rtTestWrapper.js
b/tests/testreduce/rtTestWrapper.js
index 6e62bc3..a7e9ac4 100644
--- a/tests/testreduce/rtTestWrapper.js
+++ b/tests/testreduce/rtTestWrapper.js
@@ -26,9 +26,9 @@
// If no Parsoid server was passed, start our own
var p = apiServer.startParsoidServer({
serverArgv: [
- // We want the cluster master so that timeouts
on stuck titles
- // lead to a restart.
- '--num-workers', '1',
+ // Don't start a cluster master so that
apiServer
+ // can restart Parsoid on the same port as
before.
+ '--num-workers', '0',
'--config', parsoidConfig,
],
quiet: true,
--
To view, visit https://gerrit.wikimedia.org/r/268046
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0e5d8c38a8b56382ad84e6309c741ba02e320ba2
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/parsoid
Gerrit-Branch: master
Gerrit-Owner: Subramanya Sastry <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
