Kji has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/268094

Change subject: Fixed hierarchySelect's collapsed parameter. Corrected 
anchorLinkHolders method to be static.
......................................................................

Fixed hierarchySelect's collapsed parameter. Corrected anchorLinkHolders method 
to be static.

Change-Id: I4b35d9c4cd0dc041cc8fc16e3990716ed0b780ee
---
M HierarchyBuilder_body.php
M includes/selectFromHierarchy.js
2 files changed, 4 insertions(+), 4 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/HierarchyBuilder 
refs/changes/94/268094/1

diff --git a/HierarchyBuilder_body.php b/HierarchyBuilder_body.php
index 0f65d33..c63ae8c 100644
--- a/HierarchyBuilder_body.php
+++ b/HierarchyBuilder_body.php
@@ -1019,7 +1019,7 @@
         * @return string: Wikitext formatted hierarchy where with all the link
         *  placeholders removed and replaced by html anchors.
         */
-       private function anchorLinkHolders( $hierarchy ) {
+       private static function anchorLinkHolders( $hierarchy ) {
                $pattern = '#<!--LINK \d+:\d+-->#';
                $numMatches = preg_match_all( $pattern, $hierarchy, $matches );
                if ( $numMatches !== false ) {
diff --git a/includes/selectFromHierarchy.js b/includes/selectFromHierarchy.js
index 60f76c9..e70bbd0 100644
--- a/includes/selectFromHierarchy.js
+++ b/includes/selectFromHierarchy.js
@@ -77,7 +77,7 @@
                                if ( params.hierarchy.length < 1 ) {
                                        return;
                                }
-
+                               
                                var twostate = params.threestate ? false : true;
 
                                var legacyMode = params.legacyMode;
@@ -159,8 +159,8 @@
                                        .bind( "loaded.jstree", function( 
event, data ) {
                                                obj.initializeTree( jqDivId, 
params.isDisabled,
                                                        selectedComponents, 
true, inputId, params.collapsed, legacyMode, params.threestate );
-                                               $( jqDivId )
-                                                       .jstree( "open_all" );
+                                               /*$( jqDivId )
+                                                       .jstree( "open_all" );*/
                                        } );
 
                                $( jqDivId )

-- 
To view, visit https://gerrit.wikimedia.org/r/268094
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4b35d9c4cd0dc041cc8fc16e3990716ed0b780ee
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/HierarchyBuilder
Gerrit-Branch: master
Gerrit-Owner: Kji <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to