jenkins-bot has submitted this change and it was merged.
Change subject: Remove useless drawSnakTypeSelector call in snakview::_create
......................................................................
Remove useless drawSnakTypeSelector call in snakview::_create
Since the snakview is always in non-edit mode at that point in creation,
`drawSnakTypeSelector` will only empty the snakTypeSelector. That is already
empty at that point, too, though.
Bug: T125643
Change-Id: Idd8132bdca02b57d6f737ec12f8099a26a156f14
---
M view/resources/jquery/wikibase/snakview/snakview.js
1 file changed, 0 insertions(+), 5 deletions(-)
Approvals:
Jonas Kress (WMDE): Looks good to me, approved
jenkins-bot: Verified
diff --git a/view/resources/jquery/wikibase/snakview/snakview.js
b/view/resources/jquery/wikibase/snakview/snakview.js
index 26602b7..bf3477a 100644
--- a/view/resources/jquery/wikibase/snakview/snakview.js
+++ b/view/resources/jquery/wikibase/snakview/snakview.js
@@ -155,15 +155,10 @@
// Re-render on previously generated DOM should be avoided.
However, when regenerating the
// whole snakview, every component needs to be drawn.
var propertyIsEmpty = !this.$property.contents().length,
- snakTypeSelectorIsEmpty =
!this.$snakTypeSelector.contents().length,
snakValueIsEmpty = !this.$snakValue.contents().length;
if ( propertyIsEmpty && !this._isEncapsulated() ) {
this.drawProperty();
- }
-
- if ( snakTypeSelectorIsEmpty ) {
- this.drawSnakTypeSelector();
}
if ( snakValueIsEmpty ) {
--
To view, visit https://gerrit.wikimedia.org/r/268057
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idd8132bdca02b57d6f737ec12f8099a26a156f14
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Adrian Lang <[email protected]>
Gerrit-Reviewer: Jonas Kress (WMDE) <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
