Tobias Gritschacher has submitted this change and it was merged. Change subject: (bug 43304) Refactoring of Snakview variations registration ......................................................................
(bug 43304) Refactoring of Snakview variations registration Makes the variation system of the snakview a jQuery Widget factory like system. Allows for shorter code in variation definitions and allows to extract some required information from the now required Snak constructor which has to be given when registering a new variation. Change-Id: I0534ec7a2d8e6c4e9f1f1774166865f985c4bdab --- M lib/resources/jquery.wikibase/snakview.variations/snakview.variations.Value.js M lib/resources/jquery.wikibase/snakview.variations/snakview.variations.Variation.js M lib/resources/jquery.wikibase/snakview.variations/snakview.variations.js M lib/resources/wikibase.css 4 files changed, 68 insertions(+), 22 deletions(-) Approvals: Tobias Gritschacher: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/42693 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0534ec7a2d8e6c4e9f1f1774166865f985c4bdab Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Daniel Werner <[email protected]> Gerrit-Reviewer: Tobias Gritschacher <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
