Anomie has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/268232

Change subject: Avoid making an edit before Setup.php is complete
......................................................................

Avoid making an edit before Setup.php is complete

It's less likely to break random stuff.

Change-Id: I9eef1551a64c98f3286f467693297b734f4289ee
Depends-On: Id82ca1c3e05291424e76f95055768d941f699080
---
M NewUserMessage.class.php
1 file changed, 7 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/NewUserMessage 
refs/changes/32/268232/1

diff --git a/NewUserMessage.class.php b/NewUserMessage.class.php
index 68ec474..bb03b30 100644
--- a/NewUserMessage.class.php
+++ b/NewUserMessage.class.php
@@ -185,10 +185,15 @@
         * @return bool
         */
        static function createNewUserMessageAutoCreated( $user ) {
-               global $wgNewUserMessageOnAutoCreate;
+               global $wgNewUserMessageOnAutoCreate, $wgHooks;
 
                if ( $wgNewUserMessageOnAutoCreate ) {
-                       NewUserMessage::createNewUserMessage( $user );
+                       // Wait for the SetupComplete hook, when it's safer to 
make an
+                       // edit.
+                       $wgHooks['SetupComplete'][] = function () use ( $user ) 
{
+                               NewUserMessage::createNewUserMessage( $user );
+                               return true;
+                       };
                }
 
                return true;

-- 
To view, visit https://gerrit.wikimedia.org/r/268232
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9eef1551a64c98f3286f467693297b734f4289ee
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/NewUserMessage
Gerrit-Branch: master
Gerrit-Owner: Anomie <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to