BryanDavis has uploaded a new change for review.
https://gerrit.wikimedia.org/r/268410
Change subject: Guard localStorage access with try/catch in mw.store.clear()
......................................................................
Guard localStorage access with try/catch in mw.store.clear()
If the user agent has localStorage disabled an exception will be thrown
for any operation that touches the object. We use try/catch
appropriately in most places but it was missing in mw.store.clear().
Change-Id: Idcd0e4c8ba9b0843b2ddcad0ae1781e4915e04fe
---
M resources/src/mediawiki/mediawiki.js
1 file changed, 5 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/10/268410/1
diff --git a/resources/src/mediawiki/mediawiki.js
b/resources/src/mediawiki/mediawiki.js
index b8349d0..e171b64 100644
--- a/resources/src/mediawiki/mediawiki.js
+++ b/resources/src/mediawiki/mediawiki.js
@@ -2251,7 +2251,11 @@
*/
clear: function () {
mw.loader.store.items = {};
- localStorage.removeItem(
mw.loader.store.getStoreKey() );
+ try {
+
localStorage.removeItem( mw.loader.store.getStoreKey() );
+ } catch ( e ) {
+ mw.track(
'resourceloader.exception', { exception: e, source: 'store-localstorage-clear'
} );
+ };
},
/**
--
To view, visit https://gerrit.wikimedia.org/r/268410
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idcd0e4c8ba9b0843b2ddcad0ae1781e4915e04fe
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: BryanDavis <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
